Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12506)

Issue 91570043: Replace LoggingSuite with BaseSuite

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by wallyworld
Modified:
9 years, 11 months ago
Reviewers:
mp+220154, axw
Visibility:
Public.

Description

Replace LoggingSuite with BaseSuite A mechanical change - the new BaseSuite is used in place of LoggingSuite across the codebase. This provides what LoggingSuite does but also ensures no outgoing network connections are used and also ensures the HOME var is cleared. A couple of tests in cmd are left using LoggingSuite to make it easier to extract this package separate to juju-core later. https://code.launchpad.net/~wallyworld/juju-core/use-basesuite/+merge/220154 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -433 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M agent/agent_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M agent/bootstrap_test.go View 1 chunk +5 lines, -6 lines 0 comments Download
M agent/format-1.16_whitebox_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M agent/format-1.18_whitebox_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M agent/format_whitebox_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M agent/identity_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M agent/mongo/mongo_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M agent/mongo/upgrade_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M agent/tools/diskmanager_test.go View 2 chunks +2 lines, -3 lines 0 comments Download
M agent/tools/tools_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M bzr/bzr_test.go View 2 chunks +5 lines, -5 lines 0 comments Download
M charm/dir_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M charm/repo_test.go View 7 chunks +7 lines, -10 lines 0 comments Download
M cloudinit/cloudinit_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M cloudinit/sshinit/configure_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M cmd/charm-admin/config_test.go View 2 chunks +3 lines, -4 lines 0 comments Download
M cmd/charm-admin/deletecharm_test.go View 2 chunks +3 lines, -4 lines 0 comments Download
M cmd/jujud/agent_test.go View 3 chunks +2 lines, -3 lines 0 comments Download
M cmd/jujud/bootstrap_test.go View 4 chunks +5 lines, -6 lines 0 comments Download
M cmd/jujud/run_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M cmd/plugins/local/main_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M container/directory_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M container/factory/factory_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M container/kvm/kvm_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M container/kvm/live_test.go View 2 chunks +2 lines, -3 lines 0 comments Download
M container/kvm/mock/mock-kvm_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M container/kvm/testing/test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M container/lxc/initialisation_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M container/lxc/lxc_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M downloader/downloader_test.go View 1 chunk +5 lines, -6 lines 0 comments Download
M environs/bootstrap/interruptiblestorage_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/bootstrap/state_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M environs/cloudinit_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M environs/config/authkeys_test.go View 2 chunks +4 lines, -4 lines 0 comments Download
M environs/configstore/disk_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/configstore/interface_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/httpstorage/backend_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M environs/imagemetadata/generate_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/imagemetadata/marshal_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/imagemetadata/upload_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/imagemetadata/validation_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M environs/instances/image_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/instances/instancetype_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/manual/addresses_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/manual/init_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/simplestreams/testing/testing.go View 3 chunks +4 lines, -4 lines 0 comments Download
M environs/sshstorage/storage_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M environs/tools/build_test.go View 3 chunks +4 lines, -4 lines 0 comments Download
M environs/tools/simplestreams_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/tools/storage_test.go View 2 chunks +4 lines, -4 lines 0 comments Download
M environs/tools/tools_test.go View 3 chunks +5 lines, -5 lines 0 comments Download
M environs/tools/validation_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M instance/address_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M juju/arch/arch_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M juju/conn_test.go View 5 chunks +5 lines, -60 lines 0 comments Download
A juju/osenv/export_test.go View 1 chunk +7 lines, -0 lines 0 comments Download
M juju/osenv/proxy_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M juju/osenv/vars_test.go View 2 chunks +18 lines, -17 lines 0 comments Download
M juju/testing/conn.go View 1 chunk +1 line, -1 line 0 comments Download
M replicaset/replicaset_test.go View 4 chunks +4 lines, -5 lines 0 comments Download
M rpc/jsoncodec/codec_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M rpc/reflect_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M rpc/rpc_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M state/api/state_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M state/apiserver/common/environwatcher_test.go View 2 chunks +2 lines, -3 lines 0 comments Download
M state/apiserver/common/errors_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M state/apiserver/debuglog_internal_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M state/compat_test.go View 3 chunks +5 lines, -6 lines 0 comments Download
M state/conn_test.go View 4 chunks +5 lines, -6 lines 0 comments Download
M state/initialize_test.go View 2 chunks +5 lines, -6 lines 0 comments Download
M state/megawatcher_internal_test.go View 3 chunks +5 lines, -6 lines 0 comments Download
M state/multiwatcher/multiwatcher_internal_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M state/presence/presence_test.go View 4 chunks +5 lines, -6 lines 0 comments Download
M state/settings_test.go View 3 chunks +5 lines, -6 lines 0 comments Download
M state/watcher/watcher_test.go View 4 chunks +5 lines, -6 lines 0 comments Download
M store/config_test.go View 2 chunks +4 lines, -4 lines 0 comments Download
M store/store_test.go View 5 chunks +5 lines, -6 lines 0 comments Download
M testing/filetesting/filetesting_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M testing/git.go View 1 chunk +2 lines, -3 lines 0 comments Download
M testing/mgo_test.go View 2 chunks +5 lines, -6 lines 0 comments Download
M upgrades/steps118_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M upgrades/upgrade_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M upstart/upstart_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/apt_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/command_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/exec/exec_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/fslock/fslock_test.go View 1 chunk +2 lines, -3 lines 0 comments Download
M utils/gomaxprocs_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/registry/registry_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/shell/script_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/ssh/fingerprint_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/ssh/generate_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/ssh/run_test.go View 2 chunks +2 lines, -3 lines 0 comments Download
M utils/ssh/ssh_gocrypto_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/ssh/ssh_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/tailer/tailer_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M utils/voyeur/value_test.go View 1 chunk +4 lines, -4 lines 0 comments Download
M utils/zip/zip_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M version/osversion_darwin_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M version/osversion_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M version/ubuntu/supportedseries_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M version/version_test.go View 1 chunk +4 lines, -4 lines 0 comments Download
M worker/deployer/simple_test.go View 4 chunks +3 lines, -4 lines 0 comments Download
M worker/instancepoller/aggregate_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/instancepoller/machine_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M worker/instancepoller/updater_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M worker/notifyworker_test.go View 3 chunks +3 lines, -4 lines 0 comments Download
M worker/peergrouper/desired_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/peergrouper/initiate_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M worker/peergrouper/worker_test.go View 2 chunks +2 lines, -3 lines 0 comments Download
M worker/runner_test.go View 2 chunks +4 lines, -4 lines 0 comments Download
M worker/simpleworker_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/singular/mongo_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M worker/singular/singular_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M worker/stringsworker_test.go View 3 chunks +3 lines, -4 lines 0 comments Download
M worker/terminationworker/worker_test.go View 3 chunks +4 lines, -4 lines 0 comments Download
M worker/uniter/charm/manifest_deployer_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M worker/uniter/debug/server_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/uniter/jujuc/server_test.go View 4 chunks +3 lines, -4 lines 0 comments Download
M worker/uniter/jujuc/util_test.go View 2 chunks +5 lines, -5 lines 0 comments Download
M worker/uniter/runlistener_test.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
wallyworld
Please take a look.
9 years, 11 months ago (2014-05-20 04:36:18 UTC) #1
axw
9 years, 11 months ago (2014-05-20 05:56:13 UTC) #2
On 2014/05/20 04:36:18, wallyworld wrote:
> Please take a look.

LGTM. I only looked at the first handful of files, and osenv/vars_test.go. I
assume the others are all more of the same.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b