Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(91)

Issue 9125046: More charm code cleanup.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by teknico
Modified:
10 years, 11 months ago
Reviewers:
frankban, mp+162315, gary.poster
Visibility:
Public.

Description

More charm code cleanup. Most of these changes were split from the former branch that added backend unit tests, it was getting too big and unreadable. No behavior changes, only formatting and two occasions of different expressions of the same meaning. https://code.launchpad.net/~teknico/charms/precise/juju-gui/cleanup-charm-code/+merge/162315 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : More charm code cleanup. #

Total comments: 3

Patch Set 3 : More charm code cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -47 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/backend.py View 5 chunks +7 lines, -7 lines 0 comments Download
M hooks/config-changed View 1 chunk +2 lines, -5 lines 0 comments Download
M hooks/start View 2 chunks +3 lines, -7 lines 0 comments Download
M hooks/utils.py View 1 4 chunks +5 lines, -5 lines 0 comments Download
M hooks/web-relation-joined View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/test_utils.py View 1 15 chunks +21 lines, -19 lines 0 comments Download

Messages

Total messages: 6
teknico
Please take a look.
10 years, 11 months ago (2013-05-03 09:29:53 UTC) #1
teknico
Please take a look.
10 years, 11 months ago (2013-05-03 10:37:45 UTC) #2
frankban
LGTM, thank you! https://codereview.appspot.com/9125046/diff/3001/tests/test_utils.py File tests/test_utils.py (right): https://codereview.appspot.com/9125046/diff/3001/tests/test_utils.py#newcode51 tests/test_utils.py:51: class TestAttrDict(unittest.TestCase): Just curious: why this ...
10 years, 11 months ago (2013-05-03 10:44:31 UTC) #3
teknico
Thanks for the review! https://codereview.appspot.com/9125046/diff/3001/tests/test_utils.py File tests/test_utils.py (right): https://codereview.appspot.com/9125046/diff/3001/tests/test_utils.py#newcode51 tests/test_utils.py:51: class TestAttrDict(unittest.TestCase): frankban wrote: > ...
10 years, 11 months ago (2013-05-03 11:06:53 UTC) #4
gary.poster
LGTM. Thank you. https://codereview.appspot.com/9125046/diff/3001/hooks/backend.py File hooks/backend.py (right): https://codereview.appspot.com/9125046/diff/3001/hooks/backend.py#newcode66 hooks/backend.py:66: charmhelpers.log('Setting up haproxy and Apache start ...
10 years, 11 months ago (2013-05-03 13:21:43 UTC) #5
teknico
10 years, 11 months ago (2013-05-03 13:46:22 UTC) #6
*** Submitted:

More charm code cleanup.

Most of these changes were split from the former branch that added
backend unit tests, it was getting too big and unreadable.

No behavior changes, only formatting and two occasions of different
expressions of the same meaning.

R=frankban, gary.poster
CC=
https://codereview.appspot.com/9125046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b