Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 91170044: code review 91170044: x86: x86 CSV table and decoder generator (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by rsc
Modified:
8 years, 3 months ago
Reviewers:
crawshaw
CC:
crawshaw
Visibility:
Public.

Description

x86: x86 CSV table and decoder generator This CL contains the x86 CSV table and the decoder generator that reads it. The program to generate the CSV table is not included (yet), as explained in the comments at the top of the table. The generator is used to generate the decoder in the x86/x86asm package (separate CL).

Patch Set 1 #

Patch Set 2 : diff -r 876d94cecc2e https://code.google.com/p/rsc.x86/ #

Patch Set 3 : diff -r 876d94cecc2e https://code.google.com/p/rsc.x86/ #

Total comments: 31

Patch Set 4 : diff -r d5498ce3c3f7 https://code.google.com/p/rsc.x86/ #

Patch Set 5 : diff -r d5498ce3c3f7 https://code.google.com/p/rsc.x86/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3216 lines, -0 lines) Patch
A x86.csv View 1 2 3 1 chunk +2332 lines, -0 lines 0 comments Download
A x86map/map.go View 1 2 3 4 1 chunk +884 lines, -0 lines 0 comments Download

Messages

Total messages: 8
rsc
Hello crawshaw@golang.org, I'd like you to review this change to https://code.google.com/p/rsc.x86/
8 years, 3 months ago (2014-05-07 04:17:01 UTC) #1
rsc
You don't need to focus too much on this piece except that basic familiarity with ...
8 years, 3 months ago (2014-05-07 04:17:55 UTC) #2
crawshaw
Looks good, nits and a question or two inline. Broad question: why are you packing ...
8 years, 3 months ago (2014-05-07 12:36:11 UTC) #3
rsc
https://codereview.appspot.com/91170044/diff/30001/x86.csv File x86.csv (right): https://codereview.appspot.com/91170044/diff/30001/x86.csv#newcode16 x86.csv:16: # Consult the manual for details about the meaning ...
8 years, 3 months ago (2014-05-07 18:12:35 UTC) #4
rsc
PTAL
8 years, 3 months ago (2014-05-07 18:12:55 UTC) #5
rsc
On Wed, May 7, 2014 at 8:36 AM, <crawshaw@golang.org> wrote: > Looks good, nits and ...
8 years, 3 months ago (2014-05-07 18:27:21 UTC) #6
crawshaw
LGTM
8 years, 3 months ago (2014-05-07 18:32:38 UTC) #7
rsc
8 years, 3 months ago (2014-05-08 03:32:10 UTC) #8
*** Submitted as
https://code.google.com/p/rsc/source/detail?r=66b21e781a9a&repo=x86 ***

x86: x86 CSV table and decoder generator

This CL contains the x86 CSV table and the decoder generator that reads it.
The program to generate the CSV table is not included (yet),
as explained in the comments at the top of the table.

The generator is used to generate the decoder in the x86/x86asm package
(separate CL).

LGTM=crawshaw
R=crawshaw
https://codereview.appspot.com/91170044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b