code review 91090043: cmd/ld: remove vestigial subroutines

cmd/ld: remove vestigial subroutines

Worn out and weary
Remnants of the exodus
Live on in liblink

[ality, 2014-05-05 06:31:31]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-05-05 11:56:01]

LGTM

Syllables check out. Lacks seasonal reference but will accept it.
 On May 5, 2014 2:31 AM, <ality@pbrane.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/ld: remove vestigial subroutines
>
> Worn out and weary
> Remnants of the exodus
> Live on in liblink
>
> Please review this at https://codereview.appspot.com/91090043/
>
> Affected files (+0, -109 lines):
>   M src/cmd/ld/lib.h
>   R src/cmd/ld/pass.c
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[josharian, 2014-05-05 13:45:15]

> > Worn out and weary
> > Remnants of the exodus
> > Live on in liblink

> Syllables check out. Lacks seasonal reference but will accept it.

Prefer limericks?

Said the wise old comment from liblink:
"With /dev/null there is yet no quibbling.
Despite the allure
This code can't endure.
But weep not--come meet its fine sibling."

-josh

[bradfitz, 2014-05-05 14:08:00]

On Mon, May 5, 2014 at 9:45 AM, <josharian@gmail.com> wrote:

> > Worn out and weary
>> > Remnants of the exodus
>> > Live on in liblink
>>
>
>  Syllables check out. Lacks seasonal reference but will accept it.
>>
>
> Prefer limericks?
>
> Said the wise old comment from liblink:
> "With /dev/null there is yet no quibbling.
> Despite the allure
> This code can't endure.
> But weep not--come meet its fine sibling."
>

A gopher appeared from Nantucket,
With types so shaped he could duck it.
   With old code, he chagrined,
   As his CPU spinned,
"If this code's not in Go, I will chuck it!"

[crawshaw, 2014-05-05 15:32:37]

On Mon, May 5, 2014 at 10:07 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> On Mon, May 5, 2014 at 9:45 AM, <josharian@gmail.com> wrote:
>
>> > Worn out and weary
>>> > Remnants of the exodus
>>> > Live on in liblink
>>>
>>
>>  Syllables check out. Lacks seasonal reference but will accept it.
>>>
>>
>> Prefer limericks?
>>
>> Said the wise old comment from liblink:
>> "With /dev/null there is yet no quibbling.
>> Despite the allure
>> This code can't endure.
>> But weep not--come meet its fine sibling."
>>
>
> A gopher appeared from Nantucket,
> With types so shaped he could duck it.
>    With old code, he chagrined,
>    As his CPU spinned,
> "If this code's not in Go, I will chuck it!"
>

public static void
main args System out println
"No space for poem"

[josharian, 2014-05-05 16:02:58]

>>>> > Worn out and weary
>>>> > Remnants of the exodus
>>>> > Live on in liblink
>>>
>>>
>>>> Syllables check out. Lacks seasonal reference but will accept it.
>>>
>>>
>>> Prefer limericks?
>>>
>>> Said the wise old comment from liblink:
>>> "With /dev/null there is yet no quibbling.
>>> Despite the allure
>>> This code can't endure.
>>> But weep not--come meet its fine sibling."
>>
>>
>> A gopher appeared from Nantucket,
>> With types so shaped he could duck it.
>>    With old code, he chagrined,
>>    As his CPU spinned,
>> "If this code's not in Go, I will chuck it!"
>
>
> public static void
> main args System out println
> "No space for poem"

io.Writer writes; and, having writ,
Moves on: nor all your Piety nor Wit
Shall Seek it back to cancel half a Line,
Nor all your type assertions make it a WriterAt.

[adg, 2014-05-06 18:51:05]

On 2014/05/05 16:02:58, josharian wrote:
> >>>> > Worn out and weary
> >>>> > Remnants of the exodus
> >>>> > Live on in liblink
> >>>
> >>>
> >>>> Syllables check out. Lacks seasonal reference but will accept it.
> >>>
> >>>
> >>> Prefer limericks?
> >>>
> >>> Said the wise old comment from liblink:
> >>> "With /dev/null there is yet no quibbling.
> >>> Despite the allure
> >>> This code can't endure.
> >>> But weep not--come meet its fine sibling."
> >>
> >>
> >> A gopher appeared from Nantucket,
> >> With types so shaped he could duck it.
> >>    With old code, he chagrined,
> >>    As his CPU spinned,
> >> "If this code's not in Go, I will chuck it!"
> >
> >
> > public static void
> > main args System out println
> > "No space for poem"
> 
> io.Writer writes; and, having writ,
> Moves on: nor all your Piety nor Wit
> Shall Seek it back to cancel half a Line,
> Nor all your type assertions make it a WriterAt.

Turning and turning in the widening gyre
The signal cannot reach the handler;
Things fall apart; the centre cannot hold;
Sheer panic is loosed upon the console,
The stack-filled tide is loosed, and everywhere
The ceremony of execution is downed;
The tests lack all conviction, while the code
Is full of irrational complexity.

[bradfitz, 2014-05-06 20:53:53]

‘Twas gophy, and the slithy codes,
did go and defer from their Ms,
All blocky were their G-routines,
And ye sends sched again.



On Tue, May 6, 2014 at 11:51 AM, <adg@golang.org> wrote:

> On 2014/05/05 16:02:58, josharian wrote:
>
>> >>>> > Worn out and weary
>> >>>> > Remnants of the exodus
>> >>>> > Live on in liblink
>> >>>
>> >>>
>> >>>> Syllables check out. Lacks seasonal reference but will accept it.
>> >>>
>> >>>
>> >>> Prefer limericks?
>> >>>
>> >>> Said the wise old comment from liblink:
>> >>> "With /dev/null there is yet no quibbling.
>> >>> Despite the allure
>> >>> This code can't endure.
>> >>> But weep not--come meet its fine sibling."
>> >>
>> >>
>> >> A gopher appeared from Nantucket,
>> >> With types so shaped he could duck it.
>> >>    With old code, he chagrined,
>> >>    As his CPU spinned,
>> >> "If this code's not in Go, I will chuck it!"
>> >
>> >
>> > public static void
>> > main args System out println
>> > "No space for poem"
>>
>
>  io.Writer writes; and, having writ,
>> Moves on: nor all your Piety nor Wit
>> Shall Seek it back to cancel half a Line,
>> Nor all your type assertions make it a WriterAt.
>>
>
> Turning and turning in the widening gyre
> The signal cannot reach the handler;
> Things fall apart; the centre cannot hold;
> Sheer panic is loosed upon the console,
> The stack-filled tide is loosed, and everywhere
> The ceremony of execution is downed;
> The tests lack all conviction, while the code
> Is full of irrational complexity.
>
>
> https://codereview.appspot.com/91090043/
>

[dave_cheney.net, 2014-07-16 10:52:45]

ping. ality, are you going to submit this ?

[ality, 2014-09-09 21:13:06]

On 2014/07/16 10:52:45, dfc wrote:
> ping. ality, are you going to submit this ?

This was accomplished by CL 120220043 (changeset e1156a6baee2).

Closing.