Issue 9101045: Fix #1174322 #1174385 #1175294 #1175086

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9101045: Fix #1174322 #1174385 #1175294 #1175086

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by rharding

Modified:
10 years, 12 months ago

Reviewers:
mp+162099

Visibility:
Public.

Description

Fix #1174322 #1174385 #1175294 #1175086 Filed as a single merge to update per design bugs referenced. https://code.launchpad.net/~rharding/juju-gui/design-updates3/+merge/162099 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix #1174322 #1174385 #1175294 #1175086 #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -47 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/assets/images/badge_approved_22.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/assets/images/badge_approved_40.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/badge_approved_57.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	app/assets/images/browser_searchbox_left.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	app/assets/images/browser_searchbox_right.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/assets/images/browser_searchbox_search_icon.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	app/templates/browser-search.handlebars	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/templates/charm-token.handlebars	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/views/browser/charm-full.less	View	2 chunks	+15 lines, -5 lines	0 comments	Download
M	lib/views/browser/charm-token.less	View	1 chunk	+37 lines, -27 lines	0 comments	Download
M	lib/views/browser/main.less	View	3 chunks	+19 lines, -17 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rharding

LGTM - these have been reviewed and qa'd already as their own MPs.

10 years, 12 months ago (2013-05-02 14:18:31 UTC) #2

rharding

10 years, 12 months ago (2013-05-02 14:23:49 UTC) #3

*** Submitted:

Fix #1174322 #1174385 #1175294 #1175086

Filed as a single merge to update per design bugs referenced.

R=
CC=
https://codereview.appspot.com/9101045

Expand All Messages | Collapse All Messages