Show networks in juju status

Show networks in juju status

This adds a new state method AllNetworks(), which returns
all networks in state, and also makes the necessary changes
to the API and cmd/juju so we can show networks as top-level
entities in juju status:

machines: ...
services: ...
networks:
  net1:
    provider-id: foo
    cidr: 0.1.2.0/24
    vlan-tag: 42

https://code.launchpad.net/~dimitern/juju-core/410-show-networks-in-status/+merge/217939

(do not edit description out of merge proposal)

[dimitern, 2014-05-01 16:23:02]

Please take a look.

[hduran, 2014-05-01 16:28:43]

LGTM Apart from that toubt on status

https://codereview.appspot.com/91000043/diff/1/state/apiserver/client/status.go
File state/apiserver/client/status.go (right):

https://codereview.appspot.com/91000043/diff/1/state/apiserver/client/status....
state/apiserver/client/status.go:380: return
Missing anything in this return?

[dimitern, 2014-05-01 16:39:14]

Please take a look.

https://codereview.appspot.com/91000043/diff/1/state/apiserver/client/status.go
File state/apiserver/client/status.go (right):

https://codereview.appspot.com/91000043/diff/1/state/apiserver/client/status....
state/apiserver/client/status.go:380: return
On 2014/05/01 16:28:43, hduran wrote:
> Missing anything in this return?

It's because of the named return value status, but I guess we don't need that,
will change it to return explicitly.

[gz, 2014-05-01 17:17:29]

LGTM.

https://codereview.appspot.com/91000043/diff/20001/cmd/juju/status.go
File cmd/juju/status.go (right):

https://codereview.appspot.com/91000043/diff/20001/cmd/juju/status.go#newcode97
cmd/juju/status.go:97: Networks    map[string]networkStatus `json:"networks"`
Add omitempty? Networks will just never exist in many environments.

https://codereview.appspot.com/91000043/diff/20001/cmd/juju/status.go#newcode206
cmd/juju/status.go:206: VLANTag    int        `json:"vlan-tag" yaml:"vlan-tag"`
VLANTag omitempty?

https://codereview.appspot.com/91000043/diff/20001/cmd/juju/status.go#newcode211
cmd/juju/status.go:211: func (n networkStatus) MarshalJSON() ([]byte, error) {
We should really make these methods shared...

[dimitern, 2014-05-01 18:08:03]

https://codereview.appspot.com/91000043/diff/20001/cmd/juju/status.go
File cmd/juju/status.go (right):

https://codereview.appspot.com/91000043/diff/20001/cmd/juju/status.go#newcode97
cmd/juju/status.go:97: Networks    map[string]networkStatus `json:"networks"`
On 2014/05/01 17:17:29, gz wrote:
> Add omitempty? Networks will just never exist in many environments.

Good idea, will do in a follow-up.

https://codereview.appspot.com/91000043/diff/20001/cmd/juju/status.go#newcode206
cmd/juju/status.go:206: VLANTag    int        `json:"vlan-tag" yaml:"vlan-tag"`
On 2014/05/01 17:17:29, gz wrote:
> VLANTag omitempty?

Done in a follow-up.

https://codereview.appspot.com/91000043/diff/20001/cmd/juju/status.go#newcode211
cmd/juju/status.go:211: func (n networkStatus) MarshalJSON() ([]byte, error) {
On 2014/05/01 17:17:29, gz wrote:
> We should really make these methods shared...

I'm not quite sure how to do that given goyaml issues.