Issue 9075043: Design updates fixes #1174764 #1174382 #1169196

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9075043: Design updates fixes #1174764 #1174382 #1169196

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by rharding

Modified:
10 years, 11 months ago

Reviewers:
mp+161815

Visibility:
Public.

Description

Design updates fixes #1174764 #1174382 #1169196 This is a combo branch of design updates to fix things in the UX. I've combined and landed as one since they've been reviewed and running lbox -cr and submit 4 times isn't attractive this morning. https://code.launchpad.net/~rharding/juju-gui/design-updates2/+merge/161815 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Design updates fixes #1174764 #1174382 #1169196 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -5 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	app/subapps/browser/views/charm.js	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	lib/views/browser/charm-full.less	View	3 chunks	+7 lines, -3 lines	0 comments	Download
M	lib/views/browser/charm-token.less	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rharding

LGTM self reviewing, the 4 branches here have been reviewed in single and gotten two ...

10 years, 11 months ago (2013-05-01 12:47:24 UTC) #2

rharding

10 years, 11 months ago (2013-05-01 12:51:24 UTC) #3

*** Submitted:

Design updates fixes #1174764 #1174382 #1169196

This is a combo branch of design updates to fix things in the UX.

I've combined and landed as one since they've been reviewed and running lbox
-cr and submit 4 times isn't attractive this morning.

R=
CC=
https://codereview.appspot.com/9075043

Expand All Messages | Collapse All Messages