Issue 90690043: Handle null pointer exception in destroy for Adaptor when adaptor fails to initialize

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 90690043: Handle null pointer exception in destroy for Adaptor when adaptor fails to initialize (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 12 months ago by Tanmay Vartak

Modified:
9 years, 12 months ago

Reviewers:
pjo

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

Handle null pointer exception in destroy for Adaptor when adaptor fails to initialize https://code.google.com/p/plexi/source/detail?r=c493a543319e7ee0f9a1b4f1f87dfc49486859bd&repo=sharepoint

Patch Set 1 #

Total comments: 2

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -10 lines)			Patch
M	src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java	View	1 chunk	+14 lines, -10 lines	1 comment	Download
M	test/com/google/enterprise/adaptor/sharepoint/SharePointAdaptorTest.java	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java	View	1 chunk	+7 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

pjo

9 years, 12 months ago (2014-04-23 20:00:01 UTC) #2

Thank you.  LGTM.

https://codereview.appspot.com/90690043/diff/1/src/com/google/enterprise/adap...
File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java
(right):

https://codereview.appspot.com/90690043/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:541: private
void shutdownExecutor(ExecutorService executor) {
synchronized?

https://codereview.appspot.com/90690043/diff/1/test/com/google/enterprise/ada...
File
test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java
(right):

https://codereview.appspot.com/90690043/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java:119:
assertNotNull(adaptor);
remove this assert not null?

Expand All Messages | Collapse All Messages