Issue 9060046: code review 9060046: runtime: revert 3c2cddfbdaec

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9060046: code review 9060046: runtime: revert 3c2cddfbdaec (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by brainman

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, khr

Visibility:
Public.

Description

runtime: revert 3c2cddfbdaec It appears, syscall.NewCallback still uses heap to store executable code.

Patch Set 1 #

Patch Set 2 : diff -r 3c2cddfbdaec https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3c2cddfbdaec https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3c2cddfbdaec https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	src/pkg/runtime/mem_windows.c	View	1	4 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2013-05-17 04:20:26 UTC) #1

khr

On 2013/05/17 04:20:26, brainman wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

12 years, 2 months ago (2013-05-17 04:23:04 UTC) #2

brainman

12 years, 2 months ago (2013-05-17 04:23:37 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=98d8cd2d050d ***

runtime: revert 3c2cddfbdaec

It appears, syscall.NewCallback still
uses heap to store executable code.

R=golang-dev, khr
CC=golang-dev
https://codereview.appspot.com/9060046

Expand All Messages | Collapse All Messages