Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1148)

Issue 90200045: state/apiserver/client/client.go: default series

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by jameinel
Modified:
9 years, 11 months ago
Reviewers:
mp+216734, wallyworld
Visibility:
Public.

Description

state/apiserver/client/client.go: default series Change the unspecified 'series' to match the existing state server series, rather than PreferredSeries (which is default-series if it exists, or LatestLTSSeries otherwise). This addresses bug #1311089, which makes "juju ensure-availability" bring up more machines that match the state-server that is already running. We probably still want to fix bug #1308966, which is about how we determine PreferredSeries, but this seems a more direct "when creating more machines like X, prefer them to look like X". https://code.launchpad.net/~jameinel/juju-core/ensure-availability-default-series-1311089/+merge/216734 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -13 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/apiserver/client/client.go View 1 chunk +17 lines, -5 lines 0 comments Download
M state/apiserver/client/client_test.go View 2 chunks +30 lines, -8 lines 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
9 years, 11 months ago (2014-04-22 14:09:15 UTC) #1
wallyworld
9 years, 11 months ago (2014-04-23 00:48:31 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b