Issue 9010043: code review 9010043: odbc: pin down memory used by parameters properly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9010043: code review 9010043: odbc: pin down memory used by parameters properly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by brainman

Modified:
10 years, 11 months ago

Reviewers:

CC:
golang-dev, lukemauldin

Visibility:
Public.

Description

odbc: pin down memory used by parameters properly Fixes issue 5.

Patch Set 1 #

Patch Set 2 : diff -r 0cc05e8b93ee https://code.google.com/p/odbc #

Patch Set 3 : diff -r 0cc05e8b93ee https://code.google.com/p/odbc #

Patch Set 4 : diff -r 775d8f76e92c https://code.google.com/p/odbc #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -13 lines)			Patch
M	mssql_test.go	View	1 2 3	4 chunks	+78 lines, -6 lines	0 comments	Download
M	odbcstmt.go	View	1	3 chunks	+6 lines, -0 lines	0 comments	Download
M	param.go	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/odbc

10 years, 11 months ago (2013-04-29 07:26:27 UTC) #1

lukemauldin

On 2013/04/29 07:26:27, brainman wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

10 years, 11 months ago (2013-05-02 11:49:36 UTC) #2

brainman

10 years, 11 months ago (2013-05-03 01:58:54 UTC) #3

*** Submitted as https://code.google.com/p/odbc/source/detail?r=62682477fd4e ***

odbc: pin down memory used by parameters properly

Fixes issue 5.

R=golang-dev, lukemauldin
CC=golang-dev
https://codereview.appspot.com/9010043

Expand All Messages | Collapse All Messages