Initial version of EWF multi segment file support.

These files are missing unit tests:
   + dfvfs/file_io/test_lib.py

[Joachim Metz, 2014-04-20 08:08:08]

Code updated.

[kiddi, 2014-04-24 22:45:13]

Few minor comments, otherwise good.

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io.py
File dfvfs/file_io/ewf_file_io.py (right):

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io....
dfvfs/file_io/ewf_file_io.py:105: segment_extention = '{0:s}{1:02d}'.format(
u''

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io....
dfvfs/file_io/ewf_file_io.py:108: segment_extention = '{0:s}x{1:02d}'.format(
u''

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io....
dfvfs/file_io/ewf_file_io.py:124: segment_index /= 26
I'm assuming you want this to be integer division? then have this as 

segment_index //= 26

(same above)

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io....
dfvfs/file_io/ewf_file_io.py:131: segment_extention = '{0:s}{1:s}{2:s}'.format(
u''

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io....
dfvfs/file_io/ewf_file_io.py:134: segment_extention = '{0:s}x{1:s}{2:s}'.format(
u''

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/test_lib.py
File dfvfs/file_io/test_lib.py (right):

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/test_lib.py#...
dfvfs/file_io/test_lib.py:171: self.assertEquals(file_object.get_size(), 350 *
512)
this smells like a case for a class constant... (that is the 512 sector size)

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/test_lib.py#...
dfvfs/file_io/test_lib.py:218: def _testSeek(self, parent_path_spec):
isn't this supposed to be

def testSeek

not _testSeek??

[Joachim Metz, 2014-04-25 04:46:29]

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io.py
File dfvfs/file_io/ewf_file_io.py (right):

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io....
dfvfs/file_io/ewf_file_io.py:105: segment_extention = '{0:s}{1:02d}'.format(
On 2014/04/24 22:45:13, kiddi wrote:
> u''

Done.

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io....
dfvfs/file_io/ewf_file_io.py:108: segment_extention = '{0:s}x{1:02d}'.format(
On 2014/04/24 22:45:13, kiddi wrote:
> u''

Done.

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io....
dfvfs/file_io/ewf_file_io.py:124: segment_index /= 26
On 2014/04/24 22:45:13, kiddi wrote:
> I'm assuming you want this to be integer division? then have this as 
> 
> segment_index //= 26
> 
> (same above)

Solved in a more efficient way.

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io....
dfvfs/file_io/ewf_file_io.py:131: segment_extention = '{0:s}{1:s}{2:s}'.format(
On 2014/04/24 22:45:13, kiddi wrote:
> u''

Done.

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/ewf_file_io....
dfvfs/file_io/ewf_file_io.py:134: segment_extention = '{0:s}x{1:s}{2:s}'.format(
On 2014/04/24 22:45:13, kiddi wrote:
> u''

Done.

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/test_lib.py
File dfvfs/file_io/test_lib.py (right):

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/test_lib.py#...
dfvfs/file_io/test_lib.py:171: self.assertEquals(file_object.get_size(), 350 *
512)
On 2014/04/24 22:45:13, kiddi wrote:
> this smells like a case for a class constant... (that is the 512 sector size)

Done.

https://codereview.appspot.com/89630043/diff/20001/dfvfs/file_io/test_lib.py#...
dfvfs/file_io/test_lib.py:218: def _testSeek(self, parent_path_spec):
On 2014/04/24 22:45:13, kiddi wrote:
> isn't this supposed to be
> 
> def testSeek
> 
> not _testSeek??

No, since this function is called from testSeek()

[Joachim Metz, 2014-04-25 04:47:33]

Code updated.

[kiddi, 2014-04-25 16:40:07]

Only one comment now, otherwise good to go. Let's fix this one and then we are
done

https://codereview.appspot.com/89630043/diff/30001/dfvfs/file_io/test_lib.py
File dfvfs/file_io/test_lib.py (right):

https://codereview.appspot.com/89630043/diff/30001/dfvfs/file_io/test_lib.py#...
dfvfs/file_io/test_lib.py:220: def _testSeek(self, parent_path_spec):
then I vote for this to follow our naming scheme, as in 

self._TestSeek

the only reason why have this as a camelCase is due to the unittest library...
and since this is not called by teh unit test library this should follow our
naming scheme.

[Joachim Metz, 2014-04-26 18:11:38]

Code updated.

[Joachim Metz, 2014-04-26 18:11:46]

https://codereview.appspot.com/89630043/diff/30001/dfvfs/file_io/test_lib.py
File dfvfs/file_io/test_lib.py (right):

https://codereview.appspot.com/89630043/diff/30001/dfvfs/file_io/test_lib.py#...
dfvfs/file_io/test_lib.py:220: def _testSeek(self, parent_path_spec):
SGTM

On 2014/04/25 16:40:08, kiddi wrote:
> then I vote for this to follow our naming scheme, as in 
> 
> self._TestSeek
> 
> the only reason why have this as a camelCase is due to the unittest library...
> and since this is not called by teh unit test library this should follow our
> naming scheme.

[kiddi, 2014-04-26 19:13:54]

LGTM

[Joachim Metz, 2014-04-26 19:22:02]

Code Submitted.