Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2276)

Issue 89540043: code review 89540043: cmd/go: update Package struct docs in list.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by rh
Modified:
9 years, 11 months ago
CC:
golang-codereviews
Visibility:
Public.

Description

cmd/go: update Package struct docs in list.go Update comments to mirror those in Package struct Align source as gofmt would Add missing ConflictDir field Like Package, add reminder to Context to update list.go Regenerate doc.go

Patch Set 1 #

Patch Set 2 : diff -r 70af843fed44 https://code.google.com/p/go #

Patch Set 3 : diff -r 70af843fed44 https://code.google.com/p/go #

Patch Set 4 : diff -r 70af843fed44 https://code.google.com/p/go #

Patch Set 5 : diff -r 70af843fed44 https://code.google.com/p/go #

Patch Set 6 : diff -r 70af843fed44 https://code.google.com/p/go #

Patch Set 7 : diff -r 70af843fed44 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -43 lines) Patch
M src/cmd/go/context.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/go/doc.go View 1 2 3 4 2 chunks +23 lines, -21 lines 0 comments Download
M src/cmd/go/list.go View 1 2 3 4 2 chunks +23 lines, -21 lines 0 comments Download
M src/cmd/go/pkg.go View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
rh
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years ago (2014-04-19 13:50:07 UTC) #1
rh
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years ago (2014-04-19 13:55:03 UTC) #2
minux1
What does ConflictDir mean? Its docs should be more detailed. probably it's hidden on purpose?
10 years ago (2014-04-19 18:28:49 UTC) #3
rh
On 2014/04/19 18:28:49, minux wrote: > What does ConflictDir mean? Its docs should be more ...
10 years ago (2014-04-19 22:14:07 UTC) #4
rh
Hello golang-codereviews@googlegroups.com, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years ago (2014-04-20 01:14:54 UTC) #5
gobot
10 years ago (2014-04-20 23:23:20 UTC) #6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b