code review 89520043: runtime, cmd/ld, cmd/5l, run.bash: enable external link...

runtime, cmd/ld, cmd/5l, run.bash: enable external linking on FreeBSD/ARM.
Update issue 7331

[minux1, 2014-04-19 06:13:49]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[minux1, 2014-04-19 08:00:03]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[dfc, 2014-04-19 08:41:05]

On 2014/04/19 08:00:03, minux wrote:
> Hello mailto:golang-codereviews@googlegroups.com (cc:
> mailto:golang-codereviews@googlegroups.com),
> 
> Please take another look.

Testing now.

[dfc, 2014-04-19 10:16:03]

LGTM. Tests pass but there is some complaining

ok      _/home/dfc/go/misc/cgo/test     8.471s
# _/home/dfc/go/misc/cgo/testtls
/usr/bin/ld:
$WORK/_/home/dfc/go/misc/cgo/testtls/_test/_obj_test/tls_unix.o(.debug_info+0x36):
R_ARM_ABS32 used with TLS symbol tls
# testmain
/usr/bin/ld: /home/dfc/tmp/go-link-uSdFwZ/000000.o(.debug_info+0x10d):
R_ARM_ABS32 used with TLS symbol tls
ok      _/home/dfc/go/misc/cgo/testtls  0.081s
# _/home/dfc/go/misc/cgo/testtls
/usr/bin/ld:
$WORK/_/home/dfc/go/misc/cgo/testtls/_test/_obj_test/tls_unix.o(.debug_info+0x36):
R_ARM_ABS32 used with TLS symbol tls
# testmain
/usr/bin/ld: /home/dfc/tmp/go-link-AQIncV/000000.o(.debug_info+0x10d):
R_ARM_ABS32 used with TLS symbol tls
ok      _/home/dfc/go/misc/cgo/testtls  0.083s

[minux1, 2014-04-19 18:11:07]

If we can get both CLs in before the beta, I will prepare status updates to
go1.3.txt.

On Apr 19, 2014 6:16 AM, <dave@cheney.net> wrote:
> Tests pass but there is some complaining
Thank you for testing both CLs.
yeah, I also have these warnings, but as the .debug_info section is not
generated by us, i think we can ignore them.
> ok      _/home/dfc/go/misc/cgo/test     8.471s
> # _/home/dfc/go/misc/cgo/testtls
> /usr/bin/ld:
>
$WORK/_/home/dfc/go/misc/cgo/testtls/_test/_obj_test/tls_unix.o(.debug_info+0x36):
> R_ARM_ABS32 used with TLS symbol tls
> # testmain
> /usr/bin/ld: /home/dfc/tmp/go-link-uSdFwZ/000000.o(.debug_info+0x10d):
> R_ARM_ABS32 used with TLS symbol tls
> ok      _/home/dfc/go/misc/cgo/testtls  0.081s
> # _/home/dfc/go/misc/cgo/testtls
> /usr/bin/ld:
>
$WORK/_/home/dfc/go/misc/cgo/testtls/_test/_obj_test/tls_unix.o(.debug_info+0x36):
> R_ARM_ABS32 used with TLS symbol tls
> # testmain
> /usr/bin/ld: /home/dfc/tmp/go-link-AQIncV/000000.o(.debug_info+0x10d):
> R_ARM_ABS32 used with TLS symbol tls
> ok      _/home/dfc/go/misc/cgo/testtls  0.083s
>
> https://codereview.appspot.com/89520043/

[gobot, 2014-04-20 23:23:56]

R=iant@golang.org (assigned by minux.ma@gmail.com)

[iant, 2014-04-21 01:50:31]

LGTM

[minux1, 2014-04-21 04:09:02]

*** Submitted as https://code.google.com/p/go/source/detail?r=aa8a4ab3bb68 ***

runtime, cmd/ld, cmd/5l, run.bash: enable external linking on FreeBSD/ARM.
Update issue 7331

LGTM=dave, iant
R=golang-codereviews, dave, gobot, iant
CC=golang-codereviews
https://codereview.appspot.com/89520043