Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(805)

Issue 89510043: code review 89510043: database/sql: Prevent transaction commit from closing t...

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by Thetawaves
Modified:
6 years, 1 month ago
Reviewers:
CC:
golang-codereviews, bradfitz, johto, minux1, thetawaves_gmail.com
Visibility:
Public.

Description

database/sql: Prevent transaction commit from closing transaction object on commit error. Fixes issue 7777.

Patch Set 1 #

Patch Set 2 : diff -r eef7ccb39676 https://code.google.com/p/go #

Patch Set 3 : diff -r eef7ccb39676 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M src/pkg/database/sql/sql.go View 1 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 6
Thetawaves
Hello golang-codereviews@googlegroups.com (cc: thetawaves@gmail.com), I'd like you to review this change to https://code.google.com/p/go
6 years, 9 months ago (2014-04-19 02:54:24 UTC) #1
bradfitz
You'll need a test too. On Apr 19, 2014 8:29 AM, <Thetawaves@gmail.com> wrote: > Reviewers: ...
6 years, 9 months ago (2014-04-19 15:40:52 UTC) #2
johto
On 4/19/14, 5:54 AM, Thetawaves@gmail.com wrote: > Description: > database/sql: Prevent transaction commit from closing ...
6 years, 9 months ago (2014-04-19 15:43:18 UTC) #3
bradfitz
Fwiw I haven't looked at the change or bug yet. I was only pointing out ...
6 years, 9 months ago (2014-04-19 15:45:02 UTC) #4
minux1
On Apr 19, 2014 11:43 AM, "Marko Tiikkaja" <marko@joh.to> wrote: > On 4/19/14, 5:54 AM, ...
6 years, 9 months ago (2014-04-19 18:31:40 UTC) #5
gobot
6 years, 1 month ago (2014-12-19 05:18:54 UTC) #6
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/89510043 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b