Small cleanup of EventTag and first prep for EventObject cleanup.

.

[Joachim Metz, 2014-04-19 05:48:06]

https://codereview.appspot.com/89410043/diff/1/plaso/lib/event.py
File plaso/lib/event.py (right):

https://codereview.appspot.com/89410043/diff/1/plaso/lib/event.py#newcode601
plaso/lib/event.py:601: __slots__ = (
I agree with getting rid of the __setattr__ and __getattr__ but are you sure you
want to use __slots__? There are various report that using it has side effects
as well, e.g. pickling issues.

https://codereview.appspot.com/89410043/diff/1/plaso/lib/event.py#newcode618
plaso/lib/event.py:618: """Define a string representation of the event."""
=> Retrieves a string representation of the event tag.

[Joachim Metz, 2014-04-20 08:44:49]

As discussed let's do the changes to the event objects before the introduction
of slots.

[kiddi, 2014-04-21 17:48:56]

done

https://codereview.appspot.com/89410043/diff/1/plaso/lib/event.py
File plaso/lib/event.py (right):

https://codereview.appspot.com/89410043/diff/1/plaso/lib/event.py#newcode601
plaso/lib/event.py:601: __slots__ = (
as discussed.

On 2014/04/19 05:48:06, Joachim Metz wrote:
> I agree with getting rid of the __setattr__ and __getattr__ but are you sure
you
> want to use __slots__? There are various report that using it has side effects
> as well, e.g. pickling issues.

https://codereview.appspot.com/89410043/diff/1/plaso/lib/event.py#newcode618
plaso/lib/event.py:618: """Define a string representation of the event."""
On 2014/04/19 05:48:06, Joachim Metz wrote:
> => Retrieves a string representation of the event tag.

Done.

[kiddi, 2014-04-21 17:59:39]

Code updated.

[Joachim Metz, 2014-04-22 05:41:52]

https://codereview.appspot.com/89410043/diff/20001/plaso/lib/event.py
File plaso/lib/event.py (right):

https://codereview.appspot.com/89410043/diff/20001/plaso/lib/event.py#newcode163
plaso/lib/event.py:163: # TODO: Remove the overwrite of __setattr__.
So please implement these TODOs I see no reason to not make this part of this
CL.

https://codereview.appspot.com/89410043/diff/20001/plaso/lib/event.py#newcode601
plaso/lib/event.py:601: # TODO: Enable __slots__ once we tested the first round
of changes.
Please remove this code entirely for now. Keep it in a separate git branch
locally if you want to keep it for the time being.

https://codereview.appspot.com/89410043/diff/20001/plaso/lib/event_test.py
File plaso/lib/event_test.py (right):

https://codereview.appspot.com/89410043/diff/20001/plaso/lib/event_test.py#ne...
plaso/lib/event_test.py:397: # TODO: Re-enable this once __slots__ has been
enabled.
Please remove this code entirely for now. Keep it in a separate git branch
locally if you want to keep it for the time being.

[kiddi, 2014-04-22 20:16:16]

done

https://codereview.appspot.com/89410043/diff/20001/plaso/lib/event.py
File plaso/lib/event.py (right):

https://codereview.appspot.com/89410043/diff/20001/plaso/lib/event.py#newcode163
plaso/lib/event.py:163: # TODO: Remove the overwrite of __setattr__.
as discussed this will be done in a separate follow-up CL since this requires a
bit more work.

On 2014/04/22 05:41:53, Joachim Metz wrote:
> So please implement these TODOs I see no reason to not make this part of this
> CL.

https://codereview.appspot.com/89410043/diff/20001/plaso/lib/event.py#newcode601
plaso/lib/event.py:601: # TODO: Enable __slots__ once we tested the first round
of changes.
On 2014/04/22 05:41:53, Joachim Metz wrote:
> Please remove this code entirely for now. Keep it in a separate git branch
> locally if you want to keep it for the time being.

Done.

https://codereview.appspot.com/89410043/diff/20001/plaso/lib/event_test.py
File plaso/lib/event_test.py (right):

https://codereview.appspot.com/89410043/diff/20001/plaso/lib/event_test.py#ne...
plaso/lib/event_test.py:397: # TODO: Re-enable this once __slots__ has been
enabled.
On 2014/04/22 05:41:53, Joachim Metz wrote:
> Please remove this code entirely for now. Keep it in a separate git branch
> locally if you want to keep it for the time being.

Done.

[kiddi, 2014-04-22 20:17:06]

Code updated.

[Joachim Metz, 2014-04-22 20:18:57]

LGTM

[kiddi, 2014-04-22 20:38:03]

Code Submitted.