Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1060)

Issue 89400044: Fix exception in exception handler. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by M-A
Modified:
9 years, 11 months ago
Reviewers:
vadimsh
CC:
swarming-eng_googlegroups.com
Base URL:
https://code.google.com/p/swarming@master
Visibility:
Public.

Description

Fix exception in exception handler. If self._get_next_minute_to_process() throws DeadlineExceedError, it would throw an UnboundLocalError which is not useful. R=vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=22ba221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M services/components/stats_framework.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
M-A
9 years, 11 months ago (2014-04-19 01:18:09 UTC) #1
vadimsh
lgtm
9 years, 11 months ago (2014-04-19 18:28:22 UTC) #2
M-A
9 years, 11 months ago (2014-04-21 00:46:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22ba221 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b