Issue 89320044: Code clean up. (Closed)
|
Created:
10 years ago by Joachim Metz Modified:
9 years, 12 months ago Reviewers:
kiddi CC:
log2timeline-dev_googlegroups.com Visibility:
Public. |
DescriptionThese files are missing unit tests:
+ plaso/frontend/pinfo.py + plaso/frontend/pprof.py + plaso/frontend/preg.py + plaso/frontend/utils.py + plaso/lib/engine.py + plaso/lib/lexer.py + plaso/lib/preprocess_interface.py + plaso/lib/putils.py + plaso/lib/registry.py + plaso/output/elastic.py + plaso/output/mysql_4n6.py + plaso/output/raw.py + plaso/output/sqlite_4n6.py + plaso/parsers/bencode_plugins/interface.py + plaso/parsers/olecf.py + plaso/parsers/sqlite_plugins/appusage.py + plaso/parsers/sqlite_plugins/interface.py + plaso/serializer/interface.py + plaso/winreg/path_expander.py + run_tests.py + setup.py + tools/image_export.py + tools/plaso_extract_search_history.py + utils/create_authors.py
Patch Set 1 #
Total comments: 48
Patch Set 2 : Uploading changes made to code. #Patch Set 3 : Submitted. #MessagesTotal messages: 6
Few comments, mostly looking good. https://codereview.appspot.com/89320044/diff/1/plaso/filters/filterlist_test.py File plaso/filters/filterlist_test.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/filters/filterlist_test.... plaso/filters/filterlist_test.py:60: 'Again_Dude:', u'' https://codereview.appspot.com/89320044/diff/1/plaso/filters/filterlist_test.... plaso/filters/filterlist_test.py:70: 'Rule_Dude:', u'' https://codereview.appspot.com/89320044/diff/1/plaso/frontend/plasm.py File plaso/frontend/plasm.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/frontend/plasm.py#newcode57 plaso/frontend/plasm.py:57: logging.error('IO ERROR: {0:s}'.format(details)) u'' https://codereview.appspot.com/89320044/diff/1/plaso/frontend/plasm.py#newcod... plaso/frontend/plasm.py:460: sys.stdout.write('.') u'' https://codereview.appspot.com/89320044/diff/1/plaso/frontend/plasm.py#newcod... plaso/frontend/plasm.py:463: sys.stdout.write('\n') u'' https://codereview.appspot.com/89320044/diff/1/plaso/frontend/plasm.py#newcod... plaso/frontend/plasm.py:599: sys.stdout.write('\n') u'' https://codereview.appspot.com/89320044/diff/1/plaso/frontend/preg.py File plaso/frontend/preg.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/frontend/preg.py#newcode91 plaso/frontend/preg.py:91: # TODO: add an explantion what this code is doing. this has to do with formatting, adjusting the length. But I'll add some comment there, let's keep the TODO as such until that happens. https://codereview.appspot.com/89320044/diff/1/plaso/frontend/psort.py File plaso/frontend/psort.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/frontend/psort.py#newcod... plaso/frontend/psort.py:562: diff_string = '+{0:s}'.format(diff) u'' https://codereview.appspot.com/89320044/diff/1/plaso/frontend/psort.py#newcod... plaso/frontend/psort.py:565: diff_string = '-{0:s}'.format(diff) u'' https://codereview.appspot.com/89320044/diff/1/plaso/frontend/psort.py#newcod... plaso/frontend/psort.py:567: print '-' * 80 u'' https://codereview.appspot.com/89320044/diff/1/plaso/lib/output_test.py File plaso/lib/output_test.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/lib/output_test.py#newco... plaso/lib/output_test.py:53: '\t<Date>{0:s}</Date>\n\t<Time>{1:d}</Time>\n' u'' https://codereview.appspot.com/89320044/diff/1/plaso/lib/pfilter.py File plaso/lib/pfilter.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/lib/pfilter.py#newcode162 plaso/lib/pfilter.py:162: raise objectfilter.ParseError('Unknown operator {0:s} provided.'.format( u'' https://codereview.appspot.com/89320044/diff/1/plaso/lib/pfilter.py#newcode266 plaso/lib/pfilter.py:266: raise ValueError('Type not supported [{0:s}].'.format(type(data))) u' https://codereview.appspot.com/89320044/diff/1/plaso/lib/pfilter.py#newcode448 plaso/lib/pfilter.py:448: logging.error('Filter <{0:s}> malformed: {1:s}'.format(query, exception)) u' https://codereview.appspot.com/89320044/diff/1/plaso/lib/preprocess_interface.py File plaso/lib/preprocess_interface.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/lib/preprocess_interface... plaso/lib/preprocess_interface.py:92: self.ATTRIBUTE, getattr(self._obj_store, self.ATTRIBUTE, 'N/A'))) u'N/A' https://codereview.appspot.com/89320044/diff/1/plaso/lib/utils.py File plaso/lib/utils.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/lib/utils.py#newcode188 plaso/lib/utils.py:188: # TODO: add an explantion what this code is doing. s/explanation/ https://codereview.appspot.com/89320044/diff/1/plaso/output/dynamic.py File plaso/output/dynamic.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/output/dynamic.py#newcod... plaso/output/dynamic.py:105: return '{0:04d}-{1:02d}-{2:02d}'.format( u'' https://codereview.appspot.com/89320044/diff/1/plaso/output/dynamic.py#newcod... plaso/output/dynamic.py:116: return '{0:02d}:{1:02d}:{2:02d}'.format( u'' https://codereview.appspot.com/89320044/diff/1/plaso/output/sqlite_4n6.py File plaso/output/sqlite_4n6.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/output/sqlite_4n6.py#new... plaso/output/sqlite_4n6.py:232: extra.append('{0:s}: {1:s} '.format( u'' https://codereview.appspot.com/89320044/diff/1/plaso/output/sqlite_4n6.py#new... plaso/output/sqlite_4n6.py:234: extra = ' '.join(extra) u'' https://codereview.appspot.com/89320044/diff/1/plaso/output/sqlite_4n6.py#new... plaso/output/sqlite_4n6.py:242: date_use_string = '{0:04d}-{1:02d}-{2:02d} {3:02d}:{4:02d}:{5:02d}'.format( u'' https://codereview.appspot.com/89320044/diff/1/plaso/parsers/mac_securityd.py File plaso/parsers/mac_securityd.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/parsers/mac_securityd.py... plaso/parsers/mac_securityd.py:234: u'Unable to determine year of log file.\nDefautling to: ' s/Defaulting/ https://codereview.appspot.com/89320044/diff/1/plaso/parsers/mac_securityd.py... plaso/parsers/mac_securityd.py:243: u'Unable to determine year of log file.\nDefautling to: ' s/Defaulting/ https://codereview.appspot.com/89320044/diff/1/plaso/parsers/sqlite_plugins/a... File plaso/parsers/sqlite_plugins/appusage.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/parsers/sqlite_plugins/a... plaso/parsers/sqlite_plugins/appusage.py:95: # Add a comment or remove the explicit conversion. there should be no need.... don't see why that is needed, remove this
Sign in to reply to this message.
https://codereview.appspot.com/89320044/diff/1/plaso/filters/filterlist_test.py File plaso/filters/filterlist_test.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/filters/filterlist_test.... plaso/filters/filterlist_test.py:60: 'Again_Dude:', On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/filters/filterlist_test.... plaso/filters/filterlist_test.py:70: 'Rule_Dude:', On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/frontend/plasm.py File plaso/frontend/plasm.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/frontend/plasm.py#newcode57 plaso/frontend/plasm.py:57: logging.error('IO ERROR: {0:s}'.format(details)) On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/frontend/plasm.py#newcod... plaso/frontend/plasm.py:460: sys.stdout.write('.') On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/frontend/plasm.py#newcod... plaso/frontend/plasm.py:463: sys.stdout.write('\n') On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/frontend/plasm.py#newcod... plaso/frontend/plasm.py:599: sys.stdout.write('\n') On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/frontend/preg.py File plaso/frontend/preg.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/frontend/preg.py#newcode91 plaso/frontend/preg.py:91: # TODO: add an explantion what this code is doing. On 2014/04/21 23:13:12, kiddi wrote: > this has to do with formatting, adjusting the length. But I'll add some comment > there, let's keep the TODO as such until that happens. Done. https://codereview.appspot.com/89320044/diff/1/plaso/frontend/psort.py File plaso/frontend/psort.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/frontend/psort.py#newcod... plaso/frontend/psort.py:562: diff_string = '+{0:s}'.format(diff) On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/frontend/psort.py#newcod... plaso/frontend/psort.py:565: diff_string = '-{0:s}'.format(diff) On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/frontend/psort.py#newcod... plaso/frontend/psort.py:567: print '-' * 80 On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/lib/output_test.py File plaso/lib/output_test.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/lib/output_test.py#newco... plaso/lib/output_test.py:53: '\t<Date>{0:s}</Date>\n\t<Time>{1:d}</Time>\n' On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/lib/pfilter.py File plaso/lib/pfilter.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/lib/pfilter.py#newcode162 plaso/lib/pfilter.py:162: raise objectfilter.ParseError('Unknown operator {0:s} provided.'.format( On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/lib/pfilter.py#newcode266 plaso/lib/pfilter.py:266: raise ValueError('Type not supported [{0:s}].'.format(type(data))) On 2014/04/21 23:13:12, kiddi wrote: > u' Done. https://codereview.appspot.com/89320044/diff/1/plaso/lib/pfilter.py#newcode448 plaso/lib/pfilter.py:448: logging.error('Filter <{0:s}> malformed: {1:s}'.format(query, exception)) On 2014/04/21 23:13:12, kiddi wrote: > u' Done. https://codereview.appspot.com/89320044/diff/1/plaso/lib/preprocess_interface.py File plaso/lib/preprocess_interface.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/lib/preprocess_interface... plaso/lib/preprocess_interface.py:92: self.ATTRIBUTE, getattr(self._obj_store, self.ATTRIBUTE, 'N/A'))) On 2014/04/21 23:13:12, kiddi wrote: > u'N/A' Done. https://codereview.appspot.com/89320044/diff/1/plaso/lib/utils.py File plaso/lib/utils.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/lib/utils.py#newcode188 plaso/lib/utils.py:188: # TODO: add an explantion what this code is doing. On 2014/04/21 23:13:12, kiddi wrote: > s/explanation/ Done. https://codereview.appspot.com/89320044/diff/1/plaso/output/dynamic.py File plaso/output/dynamic.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/output/dynamic.py#newcod... plaso/output/dynamic.py:105: return '{0:04d}-{1:02d}-{2:02d}'.format( On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/output/dynamic.py#newcod... plaso/output/dynamic.py:116: return '{0:02d}:{1:02d}:{2:02d}'.format( On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/output/sqlite_4n6.py File plaso/output/sqlite_4n6.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/output/sqlite_4n6.py#new... plaso/output/sqlite_4n6.py:232: extra.append('{0:s}: {1:s} '.format( On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/output/sqlite_4n6.py#new... plaso/output/sqlite_4n6.py:234: extra = ' '.join(extra) On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/output/sqlite_4n6.py#new... plaso/output/sqlite_4n6.py:242: date_use_string = '{0:04d}-{1:02d}-{2:02d} {3:02d}:{4:02d}:{5:02d}'.format( On 2014/04/21 23:13:12, kiddi wrote: > u'' Done. https://codereview.appspot.com/89320044/diff/1/plaso/parsers/mac_securityd.py File plaso/parsers/mac_securityd.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/parsers/mac_securityd.py... plaso/parsers/mac_securityd.py:234: u'Unable to determine year of log file.\nDefautling to: ' On 2014/04/21 23:13:12, kiddi wrote: > s/Defaulting/ Done. https://codereview.appspot.com/89320044/diff/1/plaso/parsers/mac_securityd.py... plaso/parsers/mac_securityd.py:243: u'Unable to determine year of log file.\nDefautling to: ' On 2014/04/21 23:13:12, kiddi wrote: > s/Defaulting/ Done. https://codereview.appspot.com/89320044/diff/1/plaso/parsers/sqlite_plugins/a... File plaso/parsers/sqlite_plugins/appusage.py (right): https://codereview.appspot.com/89320044/diff/1/plaso/parsers/sqlite_plugins/a... plaso/parsers/sqlite_plugins/appusage.py:95: # Add a comment or remove the explicit conversion. On 2014/04/21 23:13:12, kiddi wrote: > there should be no need.... don't see why that is needed, remove this Done.
Sign in to reply to this message.
Code updated.
Sign in to reply to this message.
LGTM
Sign in to reply to this message.
|
