Fixes #1167514 and #1171529 charm token display

Fixes #1167514 and #1171529 charm token display

- Hack the charm-token widget to not use the BrowserCharm.id to set the node's
ID attribute. There's no promise that the tokens are unique on a page of
display.
- Update the editorial to set the active CSS on selected charms.
- Update the subapp to make sure the editorial is rendered with a currently
selected charm if the url is actually a /sidebar/charm/id state.

https://code.launchpad.net/~rharding/juju-gui/containers-with-id-1167514/+merge/160392

(do not edit description out of merge proposal)

[rharding, 2013-04-23 14:42:19]

Please take a look.

[rharding, 2013-04-23 16:24:39]

Please take a look.

[jeff.pihach, 2013-04-23 16:24:47]

LGTM with trivial comments

Thanks

https://codereview.appspot.com/8920043/diff/1/app/subapps/browser/views/edito...
File app/subapps/browser/views/editorial.js (right):

https://codereview.appspot.com/8920043/diff/1/app/subapps/browser/views/edito...
app/subapps/browser/views/editorial.js:60: 
extra \n

https://codereview.appspot.com/8920043/diff/1/app/widgets/charm-token.js
File app/widgets/charm-token.js (right):

https://codereview.appspot.com/8920043/diff/1/app/widgets/charm-token.js#newc...
app/widgets/charm-token.js:29: @param {Node/String} the node to use for the
bounding box.
I think this is supposed to be a pipe {Node | String}

https://codereview.appspot.com/8920043/diff/1/app/widgets/charm-token.js#newc...
app/widgets/charm-token.js:35: // data passed in.
Does this use a dynamically created YUI ID? If so, maybe a quick comment to that
effect.

https://codereview.appspot.com/8920043/diff/1/app/widgets/charm-token.js#newc...
app/widgets/charm-token.js:73: 
@attribute
@type

[rharding, 2013-04-23 16:28:52]

Updated.

https://codereview.appspot.com/8920043/diff/1/app/widgets/charm-token.js
File app/widgets/charm-token.js (right):

https://codereview.appspot.com/8920043/diff/1/app/widgets/charm-token.js#newc...
app/widgets/charm-token.js:29: @param {Node/String} the node to use for the
bounding box.
On 2013/04/23 16:24:47, jeff.pihach wrote:
> I think this is supposed to be a pipe {Node | String}

Sorry, copied from the YUI src. Updated.

https://codereview.appspot.com/8920043/diff/1/app/widgets/charm-token.js#newc...
app/widgets/charm-token.js:35: // data passed in.
On 2013/04/23 16:24:47, jeff.pihach wrote:
> Does this use a dynamically created YUI ID? If so, maybe a quick comment to
that
> effect. 

Yes, it's auto generated. Comment updated.

https://codereview.appspot.com/8920043/diff/1/app/widgets/charm-token.js#newc...
app/widgets/charm-token.js:73: 
On 2013/04/23 16:24:47, jeff.pihach wrote:
> @attribute
> @type

Thanks!

[rharding, 2013-04-23 16:30:06]

Please take a look.

[j.c.sackett, 2013-04-23 16:45:42]

https://codereview.appspot.com/8920043/diff/9001/app/subapps/browser/views/ed...
File app/subapps/browser/views/editorial.js (left):

https://codereview.appspot.com/8920043/diff/9001/app/subapps/browser/views/ed...
app/subapps/browser/views/editorial.js:64: this._apiFailure(data, request,
'Failed to load sidebar content.');
Is this view no longer making API calls? Because I don't see the accompanying
change to render. Bad diff?

[rharding, 2013-04-23 16:54:25]

Please take a look.

[j.c.sackett, 2013-04-23 17:18:12]

LGTM. Thanks!

[rharding, 2013-04-23 17:30:28]

*** Submitted:

Fixes #1167514 and #1171529 charm token display

- Hack the charm-token widget to not use the BrowserCharm.id to set the node's
ID attribute. There's no promise that the tokens are unique on a page of
display.
- Update the editorial to set the active CSS on selected charms.
- Update the subapp to make sure the editorial is rendered with a currently
selected charm if the url is actually a /sidebar/charm/id state.

R=jeff.pihach, j.c.sackett
CC=
https://codereview.appspot.com/8920043