Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(702)

Issue 89150043: code review 89150043: runtime, go/build: re-enable cgo on FreeBSD. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by minux1
Modified:
9 years, 11 months ago
Reviewers:
mikio, dfc, iant
CC:
golang-codereviews, dfc, gobot, iant
Visibility:
Public.

Description

runtime, go/build: re-enable cgo on FreeBSD. Fixes issue 7331.

Patch Set 1 #

Patch Set 2 : diff -r 52977ca90909 https://code.google.com/p/go #

Patch Set 3 : diff -r 2114e9e65d6c https://code.google.com/p/go #

Patch Set 4 : diff -r aa8a4ab3bb68 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/pkg/go/build/build.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/sys_freebsd_arm.s View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8
minux1
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 11 months ago (2014-04-19 06:15:06 UTC) #1
minux1
On Apr 19, 2014 2:15 AM, <minux.ma@gmail.com> wrote: > +// TODO(minux): this only supports ARMv6K+. ...
9 years, 11 months ago (2014-04-19 06:31:55 UTC) #2
dfc
LGTM. All the link tests pass On Sat, Apr 19, 2014 at 4:31 PM, minux ...
9 years, 11 months ago (2014-04-19 10:15:02 UTC) #3
gobot
R=iant@golang.org (assigned by minux.ma@gmail.com)
9 years, 11 months ago (2014-04-20 23:24:03 UTC) #4
iant
LGTM
9 years, 11 months ago (2014-04-21 01:51:40 UTC) #5
minux1
*** Submitted as https://code.google.com/p/go/source/detail?r=c2cf1a3d6006 *** runtime, go/build: re-enable cgo on FreeBSD. Fixes issue 7331. LGTM=dave, ...
9 years, 11 months ago (2014-04-21 04:09:26 UTC) #6
mikio
Congrats minux! You've finally finished the three year-long task! On Mon, Apr 21, 2014 at ...
9 years, 11 months ago (2014-04-22 00:35:26 UTC) #7
minux1
9 years, 11 months ago (2014-04-22 01:30:09 UTC) #8
On Apr 21, 2014 8:35 PM, "Mikio Hara" <mikioh.mikioh@gmail.com> wrote:
> Congrats minux! You've finally finished the three year-long task!
In retrospective, I should just wait until FreeBSD switch to eabi before
attempting the merge.

now NetBSD has also switched to eabi, but I'm afraid I have to wait until
1.4 to fix it. (CL was available even before the formal code freeze, but my
test environment/builder broke down)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b