Issue 8911043: Fixes fullscreen

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8911043: Fixes fullscreen

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by j.c.sackett

Modified:
11 years ago

Reviewers:
curtis, mp+160131

Visibility:
Public.

Description

Fixes fullscreen Styles fullscreen charm browser and fixes full screen expansion. (landing for Huw) https://code.launchpad.net/~jcsackett/juju-gui/browser-home-page/+merge/160131 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes fullscreen #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -106 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/browser.js	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/subapps/browser/templates/editorial.handlebars	View	1 chunk	+14 lines, -2 lines	0 comments	Download
M	app/subapps/browser/templates/sidebar.handlebars	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	app/templates/charm-container.handlebars	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/templates/charm-token.handlebars	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/widgets/charm-token.js	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	lib/views/browser/charm-container.less	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	lib/views/browser/charm-full.less	View	2 chunks	+6 lines, -23 lines	0 comments	Download
M	lib/views/browser/charm-token.less	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	lib/views/browser/content-sidebar.less	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A	lib/views/browser/editorial.less	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	lib/views/browser/main.less	View	4 chunks	+54 lines, -63 lines	0 comments	Download
M	lib/views/stylesheet.less	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

j.c.sackett

11 years ago (2013-04-22 15:06:42 UTC) #4

*** Submitted:

Fixes fullscreen

Styles fullscreen charm browser and fixes full screen expansion.
(landing for Huw)

R=curtis
CC=
https://codereview.appspot.com/8911043

Expand All Messages | Collapse All Messages