Issue 8909044: Wire up the charm browser "Add" button.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by benji

Modified:
10 years, 12 months ago

Reviewers:
mp+160144, jeff.pihach, matthew.scott

Visibility:
Public.

Description

Wire up the charm browser "Add" button. When the "Add" button is clicked the charm configuration panel is displayed and the user can cancel or deploy. https://code.launchpad.net/~benji/juju-gui/wire-up-add-button/+merge/160144 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Wire up the charm browser "Add" button. #

Patch Set 3 : Wire up the charm browser "Add" button. #

Patch Set 4 : Wire up the charm browser "Add" button. #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -17 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	app/subapps/browser/browser.js	View	1 2	2 chunks	+14 lines, -2 lines	0 comments	Download
M	app/subapps/browser/views/charm.js	View		4 chunks	+26 lines, -6 lines	0 comments	Download
M	app/views/charm-panel.js	View	1	4 chunks	+36 lines, -4 lines	0 comments	Download
M	test/test_browser_charm_details.js	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM thanks, just a couple trivial comments below. https://codereview.appspot.com/8909044/diff/1/app/subapps/browser/browser.js File app/subapps/browser/browser.js (right): https://codereview.appspot.com/8909044/diff/1/app/subapps/browser/browser.js#newcode284 app/subapps/browser/browser.js:284: deploy: ...

10 years, 12 months ago (2013-04-22 16:18:45 UTC) #2

benji

Please take a look. https://codereview.appspot.com/8909044/diff/1/app/subapps/browser/browser.js File app/subapps/browser/browser.js (right): https://codereview.appspot.com/8909044/diff/1/app/subapps/browser/browser.js#newcode284 app/subapps/browser/browser.js:284: deploy: this.get('deploy') Good catch. They ...

10 years, 12 months ago (2013-04-22 17:07:32 UTC) #4

benji

10 years, 12 months ago (2013-04-22 17:11:52 UTC) #5

*** Submitted:

Wire up the charm browser "Add" button.

When the "Add" button is clicked the charm configuration panel is displayed
and the user can cancel or deploy.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/8909044

Expand All Messages | Collapse All Messages