Start the appengine-tools gem

[woodie, 2009-07-02 03:33:09]

I need to get a current copy working

http://codereview.appspot.com/89083/diff/1008/10
File README.rdoc (right):

http://codereview.appspot.com/89083/diff/1008/10#newcode2
Line 2: 
Generate XML files required by App Engine for JRuby from a rackup file.
This works from standard Ruby or JRuby, but you'll need the rack gem.         

Configure your app from within the 'config.ru' file:

  AppEngine::Rack.app.configure( :application => 'simple', :version => 2 )

Now run xmlgen.rb and and your ready to go:

  ./genxml.rb

http://codereview.appspot.com/89083/diff/1008/12
File lib/appengine-tools/genxml.rb (right):

http://codereview.appspot.com/89083/diff/1008/12#newcode21
Line 21: Dir.mkdir('WEB-INF') unless File.exists?('WEB-INF')
this is now handled inside the write methods
(which makes it possible to experiment in irb)

http://codereview.appspot.com/89083/diff/1008/12#newcode28
Line 28: aeweb.write(AppEngine::Rack.app.to_xml)
write doesn't take any arguments, even in your version.
we could move the Formatters stuff to one place.
that pretty_xml method was not intended to live on

http://codereview.appspot.com/89083/diff/1008/13
File lib/appengine-tools/web-xml.rb (right):

http://codereview.appspot.com/89083/diff/1008/13#newcode106
Line 106: 
I feel like 'e' would be fine here

e = REXML::Element.new('servlet')
. . .
xml.add_element(e)

[woodie, 2009-07-02 21:01:32]

If you want to call a method that returns nicely formatted XML, and also have
the ability to write that to a file, I think I should create a little rexml
helper class that we use for both xml files. The way it is right now, the
prexxy_xml method is returning a nil and a string, and it needs to be
depricated!

http://codereview.appspot.com/89083/diff/1008/11
File lib/appengine-tools/rack.rb (right):

http://codereview.appspot.com/89083/diff/1008/11#newcode138
Line 138: formatter.write(to_xml, out || String.new)
when we shove everything into String.new, is will fall out of the bottom of the
method, but this is horribly sloppy looking

[do_not_use, 2009-07-02 22:32:15]

http://codereview.appspot.com/89083/diff/1008/10
File README.rdoc (right):

http://codereview.appspot.com/89083/diff/1008/10#newcode2
Line 2: 
On 2009/07/02 03:33:09, mando.woodie wrote:
> Generate XML files required by App Engine for JRuby from a rackup file.
> This works from standard Ruby or JRuby, but you'll need the rack gem.         
> 
> Configure your app from within the 'config.ru' file:
> 
>   AppEngine::Rack.app.configure( :application => 'simple', :version => 2 )
> 
> Now run xmlgen.rb and and your ready to go:
> 
>   ./genxml.rb
> 

Done.

http://codereview.appspot.com/89083/diff/1008/12
File lib/appengine-tools/genxml.rb (right):

http://codereview.appspot.com/89083/diff/1008/12#newcode21
Line 21: Dir.mkdir('WEB-INF') unless File.exists?('WEB-INF')
On 2009/07/02 03:33:09, mando.woodie wrote:
> this is now handled inside the write methods
> (which makes it possible to experiment in irb)

I want to keep this here so the libraries don't depend on the working directory.

http://codereview.appspot.com/89083/diff/1008/12#newcode28
Line 28: aeweb.write(AppEngine::Rack.app.to_xml)
I'm actually calling write on the file. This must have worked by just calling
to_s on the rexml document? Anyway, I've made this more explicit now.

On 2009/07/02 03:33:09, mando.woodie wrote:
> write doesn't take any arguments, even in your version.
> we could move the Formatters stuff to one place.
> that pretty_xml method was not intended to live on

http://codereview.appspot.com/89083/diff/1008/11
File lib/appengine-tools/rack.rb (right):

http://codereview.appspot.com/89083/diff/1008/11#newcode138
Line 138: formatter.write(to_xml, out || String.new)
On 2009/07/02 21:01:32, mando.woodie wrote:
> when we shove everything into String.new, is will fall out of the bottom of
the
> method, but this is horribly sloppy looking

fixed.

http://codereview.appspot.com/89083/diff/1008/13
File lib/appengine-tools/web-xml.rb (right):

http://codereview.appspot.com/89083/diff/1008/13#newcode106
Line 106: 
I like having something to distinguish between the two different elements here. 
I changed xml_parms to e below though.

On 2009/07/02 03:33:09, mando.woodie wrote:
> I feel like 'e' would be fine here
> 
> e = REXML::Element.new('servlet')
> . . .
> xml.add_element(e)

[woodie, 2009-07-03 00:59:21]

If the resource classes were useful outside this application
it could be helpful to flip this around and have obj.to_xml,
but that will create a big mess. I like this approach...

Please append your nodes/elements to this xml document

   Resource.append_to(doc)

Using doc is not as descriptive, but is "the" standard.  :-\

nice work!

http://codereview.appspot.com/89083/diff/3001/2005
File lib/appengine-tools/rack.rb (right):

http://codereview.appspot.com/89083/diff/3001/2005#newcode19
Line 19: require 'rexml/formatters/pretty'
not used here anymore

http://codereview.appspot.com/89083/diff/3001/2005#newcode109
Line 109: def to_xml
It may be more appropriate to use doc

doc = REXML::Document...

http://codereview.appspot.com/89083/diff/3001/2008
File lib/appengine-tools/web-xml.rb (right):

http://codereview.appspot.com/89083/diff/3001/2008#newcode56
Line 56: xml = REXML::Document.new.add_element('web-app')
It may be more appropriate to use doc

doc = REXML::Document...

[woodie, 2009-07-03 02:39:57]

I need to figure out how to send diffs

http://codereview.appspot.com/89083/diff/3001/2005
File lib/appengine-tools/rack.rb (right):

http://codereview.appspot.com/89083/diff/3001/2005#newcode75
Line 75: class RackApplication
# I liked my force-to-string mod, but with your way
# you should only generate the reader for :version 

      attr_accessor :application
      attr_reader :version, :static_files, :resource_files
      attr_reader :system_properties, :environment_variables
      attr_writer :ssl_enabled, :sessions_enabled