Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2906)

Issue 8908043: Fix CI failures in Firefox unit tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by frankban
Modified:
10 years, 12 months ago
Reviewers:
mp+160061, teknico, gary.poster
Visibility:
Public.

Description

Fix CI failures in Firefox unit tests. Due to bug https://bugzilla.mozilla.org/show_bug.cgi?id=566671 the unit tests using focus/blur events fail on Firefox. For some reason, the initial Firefox window is not focused when the remote webdriver starts executing the GUI unit tests. This branch adds an explicit call to focus the main window before running the tests. https://code.launchpad.net/~frankban/juju-gui/unit-tests/+merge/160061 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix CI failures in Firefox unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M test/test_charm_running.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
10 years, 12 months ago (2013-04-22 10:26:53 UTC) #1
teknico
LGTM, let's try it, thanks.
10 years, 12 months ago (2013-04-22 10:30:20 UTC) #2
gary.poster
LGTM. Thank you! It would be awesome if this fixed it.
10 years, 12 months ago (2013-04-22 11:50:58 UTC) #3
frankban
*** Submitted: Fix CI failures in Firefox unit tests. Due to bug https://bugzilla.mozilla.org/show_bug.cgi?id=566671 the unit ...
10 years, 12 months ago (2013-04-22 11:55:33 UTC) #4
frankban
10 years, 12 months ago (2013-04-22 11:56:37 UTC) #5
On 2013/04/22 11:50:58, gary.poster wrote:
> LGTM. Thank you!  It would be awesome if this fixed it.

I hope so, trying now. Thanks for the reviews!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b