Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(530)

Issue 88980043: Fix spurious error.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by bac
Modified:
9 years, 11 months ago
Reviewers:
curtis, mp+216376
Visibility:
Public.

Description

Fix spurious error. All fixes are: Fix spurious test failure when version==0. Print bundle revid in debug message. Handle HTTPErrors from get_branch_tips and ValueErrors from parse_branch. Move implicit parse_branch test from test_lp to an explicit one in test_utils. Add Cache-Control to Launchpad API call when getting branch tips. Also use correct distribution name rather than alias. https://code.launchpad.net/~bac/charmworld/comma-migration/+merge/216376 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -23 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/jobs/ingest.py View 1 chunk +3 lines, -1 line 0 comments Download
M charmworld/jobs/lp.py View 5 chunks +17 lines, -4 lines 0 comments Download
M charmworld/jobs/tests/test_lp.py View 1 chunk +0 lines, -7 lines 0 comments Download
M charmworld/jobs/tests/test_utils.py View 2 chunks +24 lines, -6 lines 0 comments Download
M charmworld/lp.py View 1 chunk +7 lines, -2 lines 0 comments Download
M charmworld/testing/factory.py View 1 chunk +1 line, -1 line 0 comments Download
M charmworld/tests/test_lp.py View 1 chunk +1 line, -1 line 0 comments Download
M charmworld/views/api/__init__.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
bac
Please take a look.
9 years, 11 months ago (2014-04-17 18:26:00 UTC) #1
curtis
9 years, 11 months ago (2014-04-17 18:33:35 UTC) #2
LGTM thank you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b