Issue 8883048: Fix small issue with exposed rendering

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8883048: Fix small issue with exposed rendering

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by gary.poster

Modified:
11 years ago

Reviewers:
mp+160244

Visibility:
Public.

Description

Fix small issue with exposed rendering If a service was already exposed when the GUI started, trying to unexpose it would not change the visual representation. This was because we were rendering multiple instances of the exposed icon per service block, unnecessarily, and not always removing all of the ones we needed to. Now we simply only add a single exposed icon at a time. https://code.launchpad.net/~gary/juju-gui/exposed/+merge/160244 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix small issue with exposed rendering #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	app/views/topology/service.js	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

gary.poster

11 years ago (2013-04-23 01:10:30 UTC) #2

*** Submitted:

Fix small issue with exposed rendering

If a service was already exposed when the GUI started, trying to unexpose it
would not change the visual representation.  This was because we were rendering
multiple instances of the exposed icon per service block, unnecessarily, and not
always removing all of the ones we needed to.  Now we simply only add a single
exposed icon at a time.

R=
CC=
https://codereview.appspot.com/8883048

Expand All Messages | Collapse All Messages