Issue 88570043: Call bindFinished during template production

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88570043: Call bindFinished during template production (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by rafaelw

Modified:
10 years ago

Reviewers:
arv, justin, John Messerly

Base URL:
git@github.com:Polymer/TemplateBinding.git@master

Visibility:
Public.

More Reviews

Description

Call bindFinished during template production and mark stagingDocument. This will allow custom elements which wish to delay construction work if bindings are coming to detect that case and to know when binding is finished. R=arv BUG= Committed: https://github.com/Polymer/TemplateBinding/commit/1cee027

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/TemplateBinding.js	View		2 chunks	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as r1cee027 (presubmit successful).

10 years ago (2014-04-16 18:07:05 UTC) #1

arv

https://codereview.appspot.com/88570043/diff/1/src/TemplateBinding.js File src/TemplateBinding.js (right): https://codereview.appspot.com/88570043/diff/1/src/TemplateBinding.js#newcode267 src/TemplateBinding.js:267: owner.stagingDocument_.isStagingDocument = true; Is this ever used?

10 years ago (2014-04-16 18:13:06 UTC) #2

rafaelw

10 years ago (2014-04-16 21:02:59 UTC) #3

Message was sent while issue was closed.

https://codereview.appspot.com/88570043/diff/1/src/TemplateBinding.js
File src/TemplateBinding.js (right):

https://codereview.appspot.com/88570043/diff/1/src/TemplateBinding.js#newcode267
src/TemplateBinding.js:267: owner.stagingDocument_.isStagingDocument = true;
The idea is that it can be used by custom elements

On 2014/04/16 18:13:06, arv wrote:
> Is this ever used?

Expand All Messages | Collapse All Messages