Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1582)

Issue 8852043: cmd/juju: implement life in status

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by rog
Modified:
9 years, 7 months ago
Reviewers:
mp+159617, fwereade, dimitern
Visibility:
Public.

Description

cmd/juju: implement life in status https://code.launchpad.net/~rogpeppe/juju-core/293-status-life/+merge/159617 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 16

Patch Set 2 : cmd/juju: implement life in status #

Patch Set 3 : cmd/juju: implement life in status #

Patch Set 4 : cmd/juju: implement life in status #

Patch Set 5 : cmd/juju: implement life in status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -35 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/status.go View 1 2 3 8 chunks +62 lines, -33 lines 0 comments Download
M cmd/juju/status_test.go View 1 2 3 8 chunks +85 lines, -2 lines 0 comments Download

Messages

Total messages: 6
rog
Please take a look.
9 years, 7 months ago (2013-04-18 12:33:55 UTC) #1
dimitern
LGTM, although please merge trunk and change Series in machineStatus as agreed (not omitempty). https://codereview.appspot.com/8852043/diff/1/cmd/juju/status.go ...
9 years, 7 months ago (2013-04-18 12:34:33 UTC) #2
fwereade
https://codereview.appspot.com/8852043/diff/1/cmd/juju/status.go File cmd/juju/status.go (left): https://codereview.appspot.com/8852043/diff/1/cmd/juju/status.go#oldcode256 cmd/juju/status.go:256: if t, err := entity.AgentTools(); err == nil { ...
9 years, 7 months ago (2013-04-18 12:37:09 UTC) #3
rog
Please take a look. https://codereview.appspot.com/8852043/diff/1/cmd/juju/status.go File cmd/juju/status.go (right): https://codereview.appspot.com/8852043/diff/1/cmd/juju/status.go#newcode140 cmd/juju/status.go:140: status.AgentStateInfo, On 2013/04/18 12:37:09, fwereade ...
9 years, 7 months ago (2013-04-18 12:58:01 UTC) #4
fwereade
Please add life to services/relations (obscuring Alive as for units/machines). With that, LGTM.
9 years, 7 months ago (2013-04-18 13:26:08 UTC) #5
rog
9 years, 7 months ago (2013-04-18 14:34:30 UTC) #6
*** Submitted:

cmd/juju: implement life in status

R=dimitern, fwereade
CC=
https://codereview.appspot.com/8852043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b