Issue 8842045: Add constraints support to the MAAS provider.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8842045: Add constraints support to the MAAS provider.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rvba

Modified:
11 years ago

Reviewers:
mp+159572, dimitern

Visibility:
Public.

Description

Add constraints support to the MAAS provider. It does not add support for MAAS-specific constraints ('maas-name' and 'maas-tag') because juju-core currently does not support provider-specific constraints yet. Also, the constraint 'CpuPower' has no obvious meaning in MAAS so it is simply ignored (with a warning). I had to change the testservice in gomaasapi so that the 'acquire' operation is now recorded (hence the change to existing tests). [https://code.launchpad.net/~rvb/gomaasapi/record-node-acquire/+merge/159404]. This change was successfully tested in the MAAS lab. https://code.launchpad.net/~rvb/juju-core/add-constraints/+merge/159572 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -7 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/maas/environ.go	View	1 chunk	+23 lines, -2 lines	1 comment	Download
M	environs/maas/environ_test.go	View	5 chunks	+65 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dimitern

11 years ago (2013-04-18 11:16:25 UTC) #2

Nice, LGTM.

https://codereview.appspot.com/8842045/diff/1/environs/maas/environ.go
File environs/maas/environ.go (right):

https://codereview.appspot.com/8842045/diff/1/environs/maas/environ.go#newcod...
environs/maas/environ.go:240: // convertConstraints ignores CpuPower because it
cannot translated into
s/convertConstrains ignores CpuPower/CpuPower is ignored/ ?

Expand All Messages | Collapse All Messages