Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 8842045: Add constraints support to the MAAS provider.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by rvba
Modified:
9 years, 7 months ago
Reviewers:
mp+159572, dimitern
Visibility:
Public.

Description

Add constraints support to the MAAS provider. It does not add support for MAAS-specific constraints ('maas-name' and 'maas-tag') because juju-core currently does not support provider-specific constraints yet. Also, the constraint 'CpuPower' has no obvious meaning in MAAS so it is simply ignored (with a warning). I had to change the testservice in gomaasapi so that the 'acquire' operation is now recorded (hence the change to existing tests). [https://code.launchpad.net/~rvb/gomaasapi/record-node-acquire/+merge/159404]. This change was successfully tested in the MAAS lab. https://code.launchpad.net/~rvb/juju-core/add-constraints/+merge/159572 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -7 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/maas/environ.go View 1 chunk +23 lines, -2 lines 1 comment Download
M environs/maas/environ_test.go View 5 chunks +65 lines, -5 lines 0 comments Download

Messages

Total messages: 2
rvba
9 years, 7 months ago (2013-04-18 10:00:59 UTC) #1
dimitern
9 years, 7 months ago (2013-04-18 11:16:25 UTC) #2
Nice, LGTM.

https://codereview.appspot.com/8842045/diff/1/environs/maas/environ.go
File environs/maas/environ.go (right):

https://codereview.appspot.com/8842045/diff/1/environs/maas/environ.go#newcod...
environs/maas/environ.go:240: // convertConstraints ignores CpuPower because it
cannot translated into
s/convertConstrains ignores CpuPower/CpuPower is ignored/ ?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b