Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5841)

Issue 8837049: Moved loadService into endpoints.js

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by jeff.pihach
Modified:
10 years, 12 months ago
Reviewers:
bac, bcsaller, mp+160673
Visibility:
Public.

Description

Moved loadService into endpoints.js This is an interm branch before moving all of the load service code into the db. It's sole purpose is to ensure that we could remove loadService from the app and move it to it's next logical spot. The next quick follow up branch will be to move all of the service loading code into the db. Tests which directly test the code in app have been removed but the endpoint tests indirectly test the code and should be fine until it is moved into db and real tests made right away. https://code.launchpad.net/~hatch/juju-gui/set-loaded/+merge/160673 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Moved loadService into endpoints.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -220 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 5 chunks +2 lines, -65 lines 0 comments Download
M app/store/endpoints.js View 2 chunks +45 lines, -5 lines 0 comments Download
M app/views/service.js View 4 chunks +0 lines, -7 lines 0 comments Download
M test/test_app.js View 2 chunks +0 lines, -143 lines 0 comments Download

Messages

Total messages: 4
jeff.pihach
Please take a look.
10 years, 12 months ago (2013-04-24 14:50:54 UTC) #1
bcsaller
LGTM Question about the plan in the MP though, when you say DB you mean ...
10 years, 12 months ago (2013-04-24 16:31:48 UTC) #2
bac
LGTM - nice work Jeff cleaning up these service-related activities. As you mentioned on IRC ...
10 years, 12 months ago (2013-04-24 16:54:15 UTC) #3
jeff.pihach
10 years, 12 months ago (2013-04-24 17:11:34 UTC) #4
*** Submitted:

Moved loadService into endpoints.js

This is an interm branch before moving all of the load
service code into the db. It's sole purpose is to ensure
that we could remove loadService from the app and move
it to it's next logical spot. The next quick follow up
branch will be to move all of the service loading code
into the db.

Tests which directly test the code in app have been removed
but the endpoint tests indirectly test the code and should
be fine until it is moved into db and real tests made right
away.

R=
CC=
https://codereview.appspot.com/8837049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b