Issue 8818043: goose/{errors,http}: fix error formatting

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8818043: goose/{errors,http}: fix error formatting (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by dave

Modified:
10 years, 12 months ago

Reviewers:
mp+159287, jameinel, fwereade

Visibility:
Public.

Description

goose/{errors,http}: fix error formatting https://code.launchpad.net/~dave-cheney/goose/001-fmt-error/+merge/159287 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : goose/{errors,http}: fix error formatting #

Patch Set 3 : goose/{errors,http}: fix error formatting #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	errors/errors.go	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	http/client.go	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	nova/nova.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2013/04/17 04:39:53, dfc wrote: > Please take a look. Tested live on hp cloud, ...

11 years ago (2013-04-17 05:10:16 UTC) #2

jameinel

11 years ago (2013-04-17 06:27:41 UTC) #4

LGTM

Though we should have ways of exercising this code in tests. I filed
https://bugs.launchpad.net/goose/+bug/1169834 about it.

Thanks for tracking this down.

Expand All Messages | Collapse All Messages