Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(793)

Issue 8811052: Trivial: tweak fix to use removeAttr

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by gary.poster
Modified:
10 years, 11 months ago
Reviewers:
mp+160247
Visibility:
Public.

Description

Trivial: tweak fix to use removeAttr removeAttr is slightly closer to our intent with removing the ghost x and y attributes, and works a bit better practically. https://code.launchpad.net/~gary/juju-gui/jumpy/+merge/160247 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Trivial: tweak fix to use removeAttr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
[revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
app/views/charm-panel.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
gary.poster
Please take a look.
10 years, 11 months ago (2013-04-23 01:49:46 UTC) #1
gary.poster
10 years, 11 months ago (2013-04-23 01:53:33 UTC) #2
*** Submitted:

Trivial: tweak fix to use removeAttr

removeAttr is slightly closer to our intent with removing the ghost x and y
attributes, and works a bit better practically.

R=
CC=
https://codereview.appspot.com/8811052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b