Issue 8811043: Add Life to Service API information

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8811043: Add Life to Service API information

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by matthew.scott

Modified:
11 years ago

Reviewers:
mp+159255, dave, thumper

Visibility:
Public.

Description

Add Life to Service API information This is a branch from Francesco Banconi, submitted on his behalf. This branch adds Life information to Service API calls for the GUI to consume and use for making decisions regarding destroying services. This branch was QA'd by members of #juju-gui earlier today, as well. https://code.launchpad.net/~makyo/juju-core/service-life/+merge/159255 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add Life to Service API information #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -46 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/params/params.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	state/api/params/params_test.go	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
M	state/megawatcher.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	state/megawatcher_internal_test.go	View		6 chunks	+6 lines, -1 line	0 comments	Download
D	state/statecmd/resolved_test.go.THIS	View		1 chunk	+0 lines, -44 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

LGTM with minor comments. https://codereview.appspot.com/8811043/diff/1/state/api/params/params.go File state/api/params/params.go (left): https://codereview.appspot.com/8811043/diff/1/state/api/params/params.go#oldcode83 state/api/params/params.go:83: // ResolvedResults holds results of ...

11 years ago (2013-04-17 00:25:02 UTC) #3

matthew.scott

11 years ago (2013-04-17 01:04:37 UTC) #5

*** Submitted:

Add Life to Service API information

This is a branch from Francesco Banconi, submitted on his behalf.  This branch
adds Life information to Service API calls for the GUI to consume and use for
making decisions regarding destroying services.  This branch was QA'd by members
of #juju-gui earlier today, as well.

R=dfc, thumper
CC=
https://codereview.appspot.com/8811043

Expand All Messages | Collapse All Messages