Issue 8804044: environs: fix precise assumptions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8804044: environs: fix precise assumptions

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by fwereade

Modified:
11 years ago

Reviewers:
mp+159516, thumper, rog

Visibility:
Public.

Description

environs: fix precise assumptions I missed a couple of cases somewhere in the pipeline. Sorry :(. https://code.launchpad.net/~fwereade/juju-core/fix-quantal-test-1/+merge/159516 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : environs: fix precise assumptions #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -7 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/local_test.go	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	environs/openstack/local_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/testing/tools.go	View	4 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

LGTM with a couple of trivial remarks below https://codereview.appspot.com/8804044/diff/1/environs/ec2/local_test.go File environs/ec2/local_test.go (right): https://codereview.appspot.com/8804044/diff/1/environs/ec2/local_test.go#newcode260 environs/ec2/local_test.go:260: envtesting.UploadFakeTools(c, ...

11 years ago (2013-04-17 22:33:28 UTC) #3

fwereade

11 years ago (2013-04-17 22:38:20 UTC) #4

*** Submitted:

environs: fix precise assumptions

I missed a couple of cases somewhere in the pipeline. Sorry :(.

R=thumper, rog
CC=
https://codereview.appspot.com/8804044

https://codereview.appspot.com/8804044/diff/1/environs/ec2/local_test.go
File environs/ec2/local_test.go (right):

https://codereview.appspot.com/8804044/diff/1/environs/ec2/local_test.go#newc...
environs/ec2/local_test.go:260: envtesting.UploadFakeTools(c, t.env.Storage())
On 2013/04/17 22:33:28, rog wrote:
> this was a precise dependency?

openstack currently demands precise images, so without specifying series..., yes
it was.

https://codereview.appspot.com/8804044/diff/1/environs/testing/tools.go
File environs/testing/tools.go (right):

https://codereview.appspot.com/8804044/diff/1/environs/testing/tools.go#newco...
environs/testing/tools.go:17: log.Noticef("environs/testing: uploading FAKE
tools %s", vers)
(FWIW, the thinking here is that this *could* be called in a non-test context,
and if it is I want it to be as clear as possible that something crackful is
going on.)

https://codereview.appspot.com/8804044/diff/1/environs/testing/tools.go#newco...
environs/testing/tools.go:78: c.Logf("removing files: %v", names)
On 2013/04/17 22:33:28, rog wrote:
> are these log messages all still worth it?

Occasionally I've found myself in a tangle with dummy Resets and magic tool
uploads and it's nice to see what's actually happened when strangeness occurs.
And I'm logging uploads, may as well log clears :).

Expand All Messages | Collapse All Messages