Ensure state server has Mongo admin rights

Ensure state server has Mongo admin rights

The machine agent is updated so that if it
fails to open state with an unauthorized error,
then the agent will attempt to give itself
admin rights by temporarily restarting mongo
with --noauth.

There will be follow-ups to perform replset
initiation, and to upgrade the upstart config.

https://code.launchpad.net/~axwalk/juju-core/lp1306902-mongo-ensureadminuser/+merge/215821

(do not edit description out of merge proposal)

[axw, 2014-04-15 08:08:15]

Please take a look.

[rog, 2014-04-15 08:33:37]

LGTM assuming it's been tested live (both upgrade and normal bootstrap).

Good stuff.

https://codereview.appspot.com/88030043/diff/1/agent/mongo/mongo_test.go
File agent/mongo/mongo_test.go (right):

https://codereview.appspot.com/88030043/diff/1/agent/mongo/mongo_test.go#newc...
agent/mongo/mongo_test.go:156: defer inst.Destroy()
Hmm, I wonder if that was the source of some problems.

https://codereview.appspot.com/88030043/diff/1/agent/mongo/upgrade.go
File agent/mongo/upgrade.go (right):

https://codereview.appspot.com/88030043/diff/1/agent/mongo/upgrade.go#newcode92
agent/mongo/upgrade.go:92: return false, fmt.Errorf("mongod did not cleanly
terminate: %v", err)
"cannot kill mongod: %v"
?

https://codereview.appspot.com/88030043/diff/1/cmd/jujud/machine.go
File cmd/jujud/machine.go (right):

https://codereview.appspot.com/88030043/diff/1/cmd/jujud/machine.go#newcode431
cmd/jujud/machine.go:431: if errors.IsUnauthorizedError(err) {
// TODO remove this when we no longer need
// compatibility with pre-HA environments.

?

https://codereview.appspot.com/88030043/diff/1/cmd/jujud/machine.go#newcode433
cmd/jujud/machine.go:433: added, ensureErr :=
a.ensureMongoAdminUser(agentConfig, info.StatePort, namespace)
Perhaps slightly easier to follow the logic if we return
early when possible?


added, ensureErr := a.ensureMongoAdminUser(agentConfig, info.StatePort,
namespace)
if ensureErr != nil {
    return nil, fmt.Errorf("cannot ensure admin user: %v", ensureErr)
}
if !added {
    // No user added, so it's probably a genuine unauthorized error.
    return nil, err
}
st, m, err = openState(agentConfig)

[axw, 2014-04-15 08:52:28]

Please take a look.

https://codereview.appspot.com/88030043/diff/1/agent/mongo/upgrade.go
File agent/mongo/upgrade.go (right):

https://codereview.appspot.com/88030043/diff/1/agent/mongo/upgrade.go#newcode92
agent/mongo/upgrade.go:92: return false, fmt.Errorf("mongod did not cleanly
terminate: %v", err)
On 2014/04/15 08:33:38, rog wrote:
> "cannot kill mongod: %v"
> ?

Done.

https://codereview.appspot.com/88030043/diff/1/cmd/jujud/machine.go
File cmd/jujud/machine.go (right):

https://codereview.appspot.com/88030043/diff/1/cmd/jujud/machine.go#newcode431
cmd/jujud/machine.go:431: if errors.IsUnauthorizedError(err) {
On 2014/04/15 08:33:38, rog wrote:
> // TODO remove this when we no longer need
> // compatibility with pre-HA environments.
> 
> ?

Done.

https://codereview.appspot.com/88030043/diff/1/cmd/jujud/machine.go#newcode433
cmd/jujud/machine.go:433: added, ensureErr :=
a.ensureMongoAdminUser(agentConfig, info.StatePort, namespace)
On 2014/04/15 08:33:38, rog wrote:
> Perhaps slightly easier to follow the logic if we return
> early when possible?
> 
> 
> added, ensureErr := a.ensureMongoAdminUser(agentConfig, info.StatePort,
> namespace)
> if ensureErr != nil {
>     return nil, fmt.Errorf("cannot ensure admin user: %v", ensureErr)
> }
> if !added {
>     // No user added, so it's probably a genuine unauthorized error.
>     return nil, err
> }
> st, m, err = openState(agentConfig)

Done.

[axw, 2014-04-15 09:10:26]

Please take a look.