Issue 8796045: Preserve negative ports on novaservice

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8796045: Preserve negative ports on novaservice

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by gz

Modified:
11 years ago

Reviewers:
dimitern, mp+159519, wallyworld

Visibility:
Public.

Description

Preserve negative ports on novaservice Creating a security group rule with the value -1 for the ports has a special meaning in some cases, the test service needs to preserve these values rather than treating it as the ports not having been set. https://code.launchpad.net/~gz/goose/novaservice_preserve_negative_ports/+merge/159519 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	testservices/novaservice/service.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	testservices/novaservice/service_test.go	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dimitern

11 years ago (2013-04-18 08:06:32 UTC) #3

LGTM, ah I knew that, but forgot to bring it up when the original code landed.
Thanks!

Expand All Messages | Collapse All Messages