Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2655)

Issue 87710043: Do not index charm annotations in bundles.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by bac
Modified:
10 years ago
Reviewers:
j.c.sackett, mp+215731
Visibility:
Public.

Description

Do not index charm annotations in bundles. Charms in bundles have "annotations" which include information relating to the widget layout when placed in the GUI ('gui-x' and 'gui-y'). This information is ancilliary to the actual bundle and should not be searchable. The presence of such data has also caused operational problems. In production, some bundles are not being indexed due to parsing errors of the x and y coordinates. An example failure is shown here: 2014-04-11 19:12:30,096 DEBUG [pyelasticsearch][MainThread] got response {u'items': [{u'index': {u'_type': u'bundle', u'_id': u'~charmers/muletrain/wiki', u'error': u'MapperParsingException[failed to parse [data.data.services.mediawiki.annotations.gui-y]]; nested: NumberFormatException[For input string: "-117.5"]; ', u'_index': u'charms-78512'}}], u'took': 4} Unfortunately, this ingestion failure cannot be reproduced on staging or locally. Further, it appears pyelasticsearch is not returning an error in this situation but is instead silently failing to index the bundle. To QA the branch, in one window run 'make run'. In another, ingest some bundles: % bin/ingest-queued --prefix="~charmers/charms/bundles" Afterwards, go to 'localhost:2464' in your browser. Search for 'bundles' and see the ones that got ingested. Next search for 'gui-x' and see no results. https://code.launchpad.net/~bac/charmworld/es-missing-data/+merge/215731 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -48 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/jobs/ingest.py View 5 chunks +11 lines, -9 lines 0 comments Download
M charmworld/jobs/lp.py View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/jobs/tests/test_ingest.py View 8 chunks +27 lines, -14 lines 3 comments Download
M charmworld/jobs/tests/test_lp.py View 2 chunks +2 lines, -0 lines 0 comments Download
M charmworld/jobs/worker.py View 2 chunks +3 lines, -4 lines 0 comments Download
M charmworld/models.py View 2 chunks +15 lines, -2 lines 0 comments Download
M charmworld/search.py View 4 chunks +13 lines, -3 lines 0 comments Download
M charmworld/tests/test_models.py View 1 chunk +62 lines, -15 lines 0 comments Download
M docs/rebuild-elasticsearch.rst View 1 chunk +2 lines, -1 line 1 comment Download
A docs/working-with-elasticsearch.rst View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bac
Please take a look.
10 years ago (2014-04-14 18:57:47 UTC) #1
j.c.sackett
LGTM, Brad. Just a minor comment in the diff on some line length formatting. https://codereview.appspot.com/87710043/diff/1/charmworld/jobs/tests/test_ingest.py ...
10 years ago (2014-04-14 19:47:00 UTC) #2
bac
10 years ago (2014-04-14 19:56:01 UTC) #3
Thanks for the review Jon.  Sorry I forgot to warn about all the drive-by stuff.

https://codereview.appspot.com/87710043/diff/1/charmworld/jobs/tests/test_ing...
File charmworld/jobs/tests/test_ingest.py (right):

https://codereview.appspot.com/87710043/diff/1/charmworld/jobs/tests/test_ing...
charmworld/jobs/tests/test_ingest.py:199: 'Saving {}'.format(_id),
It does pass lint (which lbox runs before letting you propose).  I'll make it
like the other to be consistent.

https://codereview.appspot.com/87710043/diff/1/charmworld/jobs/tests/test_ing...
charmworld/jobs/tests/test_ingest.py:199: 'Saving {}'.format(_id),
It does pass lint (which lbox runs before letting you propose).  I'll make it
like the other to be consistent.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b