Issue 87540043: state: Use APIHostPorts to implement APIAddresses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 87540043: state: Use APIHostPorts to implement APIAddresses

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by gz

Modified:
10 years ago

Reviewers:
mp+215643, rog

Visibility:
Public.

Description

state: Use APIHostPorts to implement APIAddresses Updates APIAddresses call to get addresses directly from state, rather than via looking up which machines are state servers then returning the addresses of those machines. Various tests have been updated to work with this change. https://code.launchpad.net/~gz/juju-core/apiaddresses_use_hostport/+merge/215643 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: Use APIHostPorts to implement APIAddresses #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -17 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/testing/utils.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	state/api/testing/apiaddresser.go	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	state/apiserver/common/addresses.go	View		1 chunk	+9 lines, -3 lines	0 comments	Download
M	state/apiserver/common/addresses_test.go	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	state/apiserver/deployer/deployer_test.go	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	state/apiserver/provisioner/provisioner_test.go	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	state/apiserver/uniter/uniter_test.go	View		1 chunk	+7 lines, -4 lines	0 comments	Download
M	worker/provisioner/kvm-broker_test.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	worker/provisioner/lxc-broker_test.go	View	1	1 chunk	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

On 2014/04/14 11:41:17, gz wrote: > Please take a look. LGTM assuming it works live.

10 years ago (2014-04-14 11:43:30 UTC) #2

rog

10 years ago (2014-04-15 16:16:40 UTC) #4

https://codereview.appspot.com/87540043/diff/20001/worker/provisioner/lxc-bro...
File worker/provisioner/lxc-broker_test.go (right):

https://codereview.appspot.com/87540043/diff/20001/worker/provisioner/lxc-bro...
worker/provisioner/lxc-broker_test.go:205: c.Assert(err, gc.IsNil)
d

Expand All Messages | Collapse All Messages