Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1152)

Issue 8730044: code review 8730044: reflect: use visit structure for map key in DeepEqual (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by rh
Modified:
9 years, 2 months ago
Reviewers:
r, bradfitz
CC:
golang-dev, bradfitz, titanous, r
Visibility:
Public.

Description

reflect: use visit structure for map key in DeepEqual

Patch Set 1 #

Patch Set 2 : diff -r 0a4f1eb9372f https://code.google.com/p/go #

Patch Set 3 : diff -r 0a4f1eb9372f https://code.google.com/p/go #

Patch Set 4 : diff -r 0a4f1eb9372f https://code.google.com/p/go #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M src/pkg/reflect/deepequal.go View 1 2 3 3 chunks +10 lines, -14 lines 1 comment Download

Messages

Total messages: 10
rh
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2013-04-13 00:05:14 UTC) #1
bradfitz
Nice. Likely too late for go 1.1 but good find. Leaving for r. On Apr ...
9 years, 8 months ago (2013-04-13 00:11:29 UTC) #2
rh
Thank you for the kind words, Brad. I wish you folks all the best on ...
9 years, 8 months ago (2013-04-13 01:11:49 UTC) #3
titanous
https://codereview.appspot.com/8730044/diff/4001/src/pkg/reflect/deepequal.go File src/pkg/reflect/deepequal.go (right): https://codereview.appspot.com/8730044/diff/4001/src/pkg/reflect/deepequal.go#newcode22 src/pkg/reflect/deepequal.go:22: func deepValueEqual(v1, v2 Value, visited map[visit]bool, depth int) bool ...
9 years, 7 months ago (2013-04-13 15:36:31 UTC) #4
r
This can wait until after Go 1.1. It might be worth writing a benchmark.
9 years, 7 months ago (2013-04-14 17:13:25 UTC) #5
r
unresolved comments. want to address them? i am fine with this as is, however. bool ...
9 years, 6 months ago (2013-05-15 21:37:18 UTC) #6
bradfitz
LGTM too. I think bool is actually better than struct{} for readability. On Wed, May ...
9 years, 6 months ago (2013-05-15 21:40:38 UTC) #7
r
LGTM
9 years, 6 months ago (2013-05-15 21:45:34 UTC) #8
r
I'll check it in. A benchmark can come later if someone is eager (I'm not). ...
9 years, 6 months ago (2013-05-15 21:45:41 UTC) #9
r
9 years, 6 months ago (2013-05-15 21:51:01 UTC) #10
*** Submitted as https://code.google.com/p/go/source/detail?r=9f146b985681 ***

reflect: use visit structure for map key in DeepEqual

R=golang-dev, bradfitz, jonathan, r
CC=golang-dev
https://codereview.appspot.com/8730044

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b