Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 8721043: Implement remove_units in go env

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by matthew.scott
Modified:
8 years, 7 months ago
Reviewers:
bac, mp+158688, jeff.pihach
Visibility:
Public.

Description

Implement remove_units in go env https://code.launchpad.net/~makyo/juju-gui/go-remove-units-1168310/+merge/158688 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Implement remove_units in go env #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/go.js View 1 1 chunk +44 lines, -0 lines 0 comments Download
M test/test_env_go.js View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
8 years, 7 months ago (2013-04-12 17:47:17 UTC) #1
jeff.pihach
LGTM - let there be remove_units!
8 years, 7 months ago (2013-04-12 18:10:28 UTC) #2
bac
LGTM with a couple of small documentation requests. https://codereview.appspot.com/8721043/diff/1/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/8721043/diff/1/app/store/env/go.js#newcode435 app/store/env/go.js:435: operation ...
8 years, 7 months ago (2013-04-12 19:02:05 UTC) #3
matthew.scott
8 years, 7 months ago (2013-04-12 19:28:12 UTC) #4
*** Submitted:

Implement remove_units in go env

R=jeff.pihach, bac
CC=
https://codereview.appspot.com/8721043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b