Issue 8713043: Fix add_relation in fakebackend.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8713043: Fix add_relation in fakebackend.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by bac

Modified:
11 years ago

Reviewers:
mp+158650, benji, gary.poster

Visibility:
Public.

Description

Fix add_relation in fakebackend. https://code.launchpad.net/~bac/juju-gui/add-relation-fix/+merge/158650 (do not edit description out of merge proposal)

Patch Set 2 : Fix add_relation in fakebackend. #

Total comments: 2

Patch Set 3 : Fix add_relation in fakebackend. #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/models.js	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	app/store/env/fakebackend.js	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	test/test_fakebackend.js	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

benji

Looks good. (I find LGTM impersonal.) https://codereview.appspot.com/8713043/diff/4001/app/models/models.js File app/models/models.js (right): https://codereview.appspot.com/8713043/diff/4001/app/models/models.js#newcode398 app/models/models.js:398: return endpoint[0] === ...

11 years ago (2013-04-12 16:02:19 UTC) #4

bac

11 years ago (2013-04-12 16:11:36 UTC) #5

*** Submitted:

Fix add_relation in fakebackend.

R=gary.poster, benji
CC=
https://codereview.appspot.com/8713043

https://codereview.appspot.com/8713043/diff/4001/app/models/models.js
File app/models/models.js (right):

https://codereview.appspot.com/8713043/diff/4001/app/models/models.js#newcode398
app/models/models.js:398: return endpoint[0] === service_id; });
fixed.

Expand All Messages | Collapse All Messages