Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(410)

Issue 8713043: Fix add_relation in fakebackend.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by bac
Modified:
8 years, 7 months ago
Reviewers:
mp+158650, benji, gary.poster
Visibility:
Public.

Description

Fix add_relation in fakebackend. https://code.launchpad.net/~bac/juju-gui/add-relation-fix/+merge/158650 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix add_relation in fakebackend. #

Total comments: 2

Patch Set 3 : Fix add_relation in fakebackend. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/models.js View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M app/store/env/fakebackend.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M test/test_fakebackend.js View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
8 years, 7 months ago (2013-04-12 15:36:29 UTC) #1
gary.poster
LGTM
8 years, 7 months ago (2013-04-12 15:38:00 UTC) #2
bac
Please take a look.
8 years, 7 months ago (2013-04-12 15:57:39 UTC) #3
benji
Looks good. (I find LGTM impersonal.) https://codereview.appspot.com/8713043/diff/4001/app/models/models.js File app/models/models.js (right): https://codereview.appspot.com/8713043/diff/4001/app/models/models.js#newcode398 app/models/models.js:398: return endpoint[0] === ...
8 years, 7 months ago (2013-04-12 16:02:19 UTC) #4
bac
8 years, 7 months ago (2013-04-12 16:11:36 UTC) #5
*** Submitted:

Fix add_relation in fakebackend.

R=gary.poster, benji
CC=
https://codereview.appspot.com/8713043

https://codereview.appspot.com/8713043/diff/4001/app/models/models.js
File app/models/models.js (right):

https://codereview.appspot.com/8713043/diff/4001/app/models/models.js#newcode398
app/models/models.js:398: return endpoint[0] === service_id; });
fixed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b