Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(377)

Issue 86990043: i#934:Convert from inline to cross-platform.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by Priyank Bhatt
Modified:
9 years, 11 months ago
Reviewers:
zhaoqin, bruening
CC:
drmemory-devs_googlegroups.com
Base URL:
http://drmemory.googlecode.com/svn/trunk/tests/
Visibility:
Public.

Description

Converted all functions to cross-platform, tested build for both Linux and windows as well as tested for both 32bit and 64bit all were successful.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -177 lines) Patch
M tests/CMakeLists.txt View 1 2 3 4 3 chunks +3 lines, -1 line 0 comments Download
M tests/addronly-reg.out View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M tests/addronly-reg.res View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M tests/registers.c View 1 2 3 4 5 20 chunks +167 lines, -129 lines 0 comments Download
M tests/registers.out View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M tests/registers.res View 1 2 3 4 1 chunk +37 lines, -37 lines 0 comments Download
M tests/registers.pattern.out View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M tests/registers.pattern.res View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M tests/unaddronly-reg.out View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tests/unaddronly-reg.res View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Priyank Bhatt
9 years, 11 months ago (2014-04-11 17:30:01 UTC) #1
Priyank Bhatt
I have attached the unaddronly-reg. Tested the build for 32bit and 64bit for both Linux ...
9 years, 11 months ago (2014-04-16 01:44:49 UTC) #2
bruening
On 2014/04/16 01:44:49, Priyank Bhatt wrote: > Tested the build for 32bit and 64bit for ...
9 years, 11 months ago (2014-04-16 16:44:40 UTC) #3
Priyank Bhatt
I have used pre-commit test suite for unix but for windows i manually builded 32bit ...
9 years, 11 months ago (2014-04-17 15:56:09 UTC) #4
Priyank Bhatt
Shall I close this Issue if not needed.
9 years, 11 months ago (2014-04-25 03:37:59 UTC) #5
zhaoqin
On 2014/04/25 03:37:59, Priyank Bhatt wrote: > Shall I close this Issue if not needed. ...
9 years, 11 months ago (2014-04-25 15:33:18 UTC) #6
Priyank Bhatt
Ok no problem. On Friday, 25 April 2014, <zhaoqin@google.com> wrote: > On 2014/04/25 03:37:59, Priyank ...
9 years, 11 months ago (2014-04-25 15:55:37 UTC) #7
zhaoqin
9 years, 11 months ago (2014-05-01 21:27:46 UTC) #8
LGTM
I will take it over from here.
Thanks
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b