Issue 86370044: code review 86370044: ogle/program/server: detect elf.EM_X86_64.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 86370044: code review 86370044: ogle/program/server: detect elf.EM_X86_64. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by nigeltao

Modified:
10 years ago

Reviewers:
r

Visibility:
Public.

Description

ogle/program/server: detect elf.EM_X86_64.

Patch Set 2 : diff -r 566b73960f9b https://code.google.com/p/ogle #

Patch Set 3 : diff -r 566b73960f9b https://code.google.com/p/ogle #

Patch Set 4 : diff -r 566b73960f9b https://code.google.com/p/ogle #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	program/server/server.go	View	1	1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle

10 years ago (2014-04-10 05:43:11 UTC) #1

nigeltao

*** Submitted as https://code.google.com/p/ogle/source/detail?r=1499b4620b27 *** ogle/program/server: detect elf.EM_X86_64. TBR=r R=r https://codereview.appspot.com/86370044

10 years ago (2014-04-10 05:45:12 UTC) #2

https://codereview.appspot.com/86370044/diff/60001/program/server/server.go File program/server/server.go (right): https://codereview.appspot.com/86370044/diff/60001/program/server/server.go#newcode92 program/server/server.go:92: return &arch.AMD64, dwarfData, nil what is the difference between ...

10 years ago (2014-04-10 06:47:16 UTC) #3

nigeltao

10 years ago (2014-04-11 01:48:00 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/86370044/diff/60001/program/server/server.go
File program/server/server.go (right):

https://codereview.appspot.com/86370044/diff/60001/program/server/server.go#n...
program/server/server.go:92: return &arch.AMD64, dwarfData, nil
On 2014/04/10 06:47:17, r wrote:
> what is the difference between the machines recognized here vs. two lines up?

I don't know, but on my linux/amd64 desktop (Ubuntu 12.04, Go tip), gc's
binaries are apparently EM_X86_64.

Expand All Messages | Collapse All Messages