Issue 8622043: code review 8622043: cmd/ld: fix argument passing in doc.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8622043: code review 8622043: cmd/ld: fix argument passing in doc.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by minux1

Modified:
11 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Patch Set 2 : diff -r b27b1ff18f39 https://code.google.com/p/go #

Patch Set 3 : diff -r b27b1ff18f39 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r b27b1ff18f39 https://code.google.com/p/go/ #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	src/cmd/ld/doc.go	View	1 2	1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years ago (2013-04-10 13:10:29 UTC) #1

minux1

PTAL. https://codereview.appspot.com/8622043/diff/9001/src/cmd/ld/doc.go File src/cmd/ld/doc.go (left): https://codereview.appspot.com/8622043/diff/9001/src/cmd/ld/doc.go#oldcode40 src/cmd/ld/doc.go:40: -Hnetbsd (only in 6l/8l) also deleted "(only in ...

11 years ago (2013-04-10 13:11:55 UTC) #2

minux1

11 years ago (2013-04-10 20:04:16 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=ec61d4bec902 ***

cmd/ld: fix argument passing in doc.go

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/8622043

Expand All Messages | Collapse All Messages