Update the charm details to show changelog detail

Update the charm details to show changelog detail

- Update the model to pull/parse the commit data from the source_code data
- add some model tests around the parsing of the commit data and a couple of
other model attrs
- Update the view to handle getting the commit data into stuff that's
handlebars friendly
- update to display/show/hide changelog details.

https://code.launchpad.net/~rharding/juju-gui/changelog/+merge/158094

(do not edit description out of merge proposal)

[rharding, 2013-04-10 12:46:49]

Please take a look.

[j.c.sackett, 2013-04-10 14:09:14]

This looks pretty good.

One thing to note is that with recent commits being actual commit data instead
of a number (like recent downloads) charm token has to be changed as well. Our
previous assumptions were that both would be numerical.

https://codereview.appspot.com/8621043/diff/1/app/models/charm.js
File app/models/charm.js (left):

https://codereview.appspot.com/8621043/diff/1/app/models/charm.js#oldcode344
app/models/charm.js:344: if (cfg.commits_in_last_30_days) {
If you're deleting this, you can actually inline that if (cfg) with if
(cfg.downloads...)

i.e. if(cfg && cfg.downloads...)

[rharding, 2013-04-10 14:34:19]

Thanks JC. There's still some work to do around that. Currently the revisions
are the last 10 which might not be the last 30 days worth. However, Aaron is
working on finishing out the api which should fill in the
commits_in_last_30_days. So I'm keeping it for now. Once he finishes that up
we'll look at if we need to do the math client side or not.

https://codereview.appspot.com/8621043/diff/1/app/models/charm.js
File app/models/charm.js (left):

https://codereview.appspot.com/8621043/diff/1/app/models/charm.js#oldcode344
app/models/charm.js:344: if (cfg.commits_in_last_30_days) {
On 2013/04/10 14:09:14, j.c.sackett wrote:
> If you're deleting this, you can actually inline that if (cfg) with if
> (cfg.downloads...)
> 
> i.e. if(cfg && cfg.downloads...)

doh, thanks

[jeff.pihach, 2013-04-10 14:40:01]

LGTM Thanks - just a couple small comments below.

https://codereview.appspot.com/8621043/diff/1/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/8621043/diff/1/app/models/charm.js#newcode484
app/models/charm.js:484: * Quoted for lazy loading purposes.
this will show up as the description for the attribute in the docs. Should
probably move it outside of the yuidoc block.

https://codereview.appspot.com/8621043/diff/1/app/subapps/browser/templates/b...
File app/subapps/browser/templates/browser_charm.handlebars (right):

https://codereview.appspot.com/8621043/diff/1/app/subapps/browser/templates/b...
app/subapps/browser/templates/browser_charm.handlebars:61: Change log
I think ChangeLog is one word

https://codereview.appspot.com/8621043/diff/1/test/test_browser_charm_details.js
File test/test_browser_charm_details.js (right):

https://codereview.appspot.com/8621043/diff/1/test/test_browser_charm_details...
test/test_browser_charm_details.js:295: var view = new CharmView({
I don't think you intended to make this a local variable.

[rharding, 2013-04-10 16:11:09]

Please take a look.

[j.c.sackett, 2013-04-10 16:39:18]

LGTM--thanks for those updates.

[rharding, 2013-04-10 17:02:20]

*** Submitted:

Update the charm details to show changelog detail

- Update the model to pull/parse the commit data from the source_code data
- add some model tests around the parsing of the commit data and a couple of
other model attrs
- Update the view to handle getting the commit data into stuff that's
handlebars friendly
- update to display/show/hide changelog details.

R=j.c.sackett, jeff.pihach
CC=
https://codereview.appspot.com/8621043