Issue 86070045: save per-delegate binding map, to avoid excess parsing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 86070045: save per-delegate binding map, to avoid excess parsing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by rafaelw

Modified:
10 years ago

Reviewers:
arv, John Messerly, justin

Base URL:
https://github.com/Polymer/TemplateBinding.git@master

Visibility:
Public.

More Reviews

Description

save per-delegate binding map, to avoid excess parsing R=arv BUG= Committed: https://github.com/Polymer/TemplateBinding/commit/180e4b5

Patch Set 1 #

Total comments: 3

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -11 lines)			Patch
	M	src/TemplateBinding.js	View		4 chunks	+40 lines, -11 lines	3 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as r180e4b5 (presubmit successful).

10 years ago (2014-04-10 21:12:41 UTC) #1

arv

10 years ago (2014-04-11 14:45:07 UTC) #3

Message was sent while issue was closed.

LGTM

https://codereview.appspot.com/86070045/diff/1/src/TemplateBinding.js
File src/TemplateBinding.js (right):

https://codereview.appspot.com/86070045/diff/1/src/TemplateBinding.js#newcode517
src/TemplateBinding.js:517: var map = getInstanceBindingMap(content, delegate_);
s/delegate_/delegate/

https://codereview.appspot.com/86070045/diff/1/src/TemplateBinding.js#newcode919
src/TemplateBinding.js:919: // delegate gets the opportunity to prepare* the
template content once
"prepare*" ?

https://codereview.appspot.com/86070045/diff/1/src/TemplateBinding.js#newcode927
src/TemplateBinding.js:927: var map = delegate_.bindingMaps[contentId];
It looks like contentId is only used as a key in the map. Maybe call it
getContentHash or getContentUid or something more specific?

Expand All Messages | Collapse All Messages