Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(741)

Issue 8601044: code review 8601044: cmd/gc: compute initialization order for top-level blan... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by remyoudompheng
Modified:
9 years ago
Reviewers:
DMorsing, rsc
CC:
golang-dev, rsc, iant, r, DMorsing
Visibility:
Public.

Description

cmd/gc: compute initialization order for top-level blank vars too. Fixes issue 5244.

Patch Set 1 #

Patch Set 2 : diff -r b27b1ff18f39 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1c764773c6ce https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c12672b17884 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r c56c0d1f613e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M src/cmd/gc/sinit.c View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
A test/fixedbugs/issue5244.go View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years ago (2013-06-10 21:38:31 UTC) #1
rsc
LGTM Ian, what do you think about this for Go 1.1.1?
9 years ago (2013-06-10 22:25:22 UTC) #2
iant
On Mon, Jun 10, 2013 at 3:25 PM, <rsc@golang.org> wrote: > LGTM > > Ian, ...
9 years ago (2013-06-10 22:35:25 UTC) #3
r
I think 1.1.1 is warranted
9 years ago (2013-06-10 22:57:54 UTC) #4
DMorsing
LGTM with one suggestion you can put in if you want. https://codereview.appspot.com/8601044/diff/9001/src/cmd/gc/sinit.c File src/cmd/gc/sinit.c (right): ...
9 years ago (2013-06-11 18:40:51 UTC) #5
rsc
Let's keep the declaration class for now, please. I don't know what else would break ...
9 years ago (2013-06-11 18:53:53 UTC) #6
remyoudompheng
9 years ago (2013-06-11 20:22:19 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=3a74e15c5d56 ***

cmd/gc: compute initialization order for top-level blank vars too.

Fixes issue 5244.

R=golang-dev, rsc, iant, r, daniel.morsing
CC=golang-dev
https://codereview.appspot.com/8601044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b