|
various: Add network tags from names; provider id
Fixes #1304905: Networks now have juju names used to
identify them, and construct tags from that for the
API, provider-specific id (currently the same as the
name, but is a distinct field).
Comments updated to better explain the difference
between juju-specific network names and provider-
specific ones (at present both are the same, but
this will change).
Few drive-by fixes are included as well.
https://code.launchpad.net/~dimitern/juju-core/394-network-name-to-id-and-add-tags/+merge/214962
Requires: https://code.launchpad.net/~dimitern/juju-core/393-provisioner-allow-adding-networks/+merge/214720
(do not edit description out of merge proposal)
Total comments: 17
Total comments: 73
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+650 lines, -221 lines) |
Patch |
|
A |
[revision details]
|
View
|
1
2
3
4
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
cmd/juju/deploy.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
environs/broker.go
|
View
|
1
2
3
|
1 chunk |
+19 lines, -4 lines |
0 comments
|
Download
|
|
M |
errors/errors.go
|
View
|
1
2
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
errors/errors_test.go
|
View
|
1
2
|
3 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
|
A |
names/network.go
|
View
|
1
2
3
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
|
A |
names/network_test.go
|
View
|
1
2
|
1 chunk |
+52 lines, -0 lines |
0 comments
|
Download
|
|
M |
names/tag.go
|
View
|
|
3 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
names/tag_test.go
|
View
|
|
3 chunks |
+13 lines, -1 line |
0 comments
|
Download
|
|
M |
provider/dummy/environs.go
|
View
|
1
2
|
1 chunk |
+6 lines, -1 line |
0 comments
|
Download
|
|
M |
provider/maas/environ.go
|
View
|
1
2
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
state/addmachine.go
|
View
|
1
2
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
state/address.go
|
View
|
1
2
3
|
2 chunks |
+9 lines, -2 lines |
0 comments
|
Download
|
|
M |
state/api/client.go
|
View
|
1
2
3
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
state/api/params/internal.go
|
View
|
1
2
3
|
2 chunks |
+25 lines, -9 lines |
0 comments
|
Download
|
|
M |
state/api/provisioner/machine.go
|
View
|
1
2
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
state/api/provisioner/provisioner_test.go
|
View
|
1
2
|
3 chunks |
+29 lines, -20 lines |
0 comments
|
Download
|
|
M |
state/apiserver/client/client.go
|
View
|
1
2
|
3 chunks |
+25 lines, -3 lines |
0 comments
|
Download
|
|
M |
state/apiserver/client/client_test.go
|
View
|
1
|
1 chunk |
+10 lines, -1 line |
0 comments
|
Download
|
|
M |
state/apiserver/provisioner/provisioner.go
|
View
|
1
2
3
4
|
3 chunks |
+51 lines, -7 lines |
0 comments
|
Download
|
|
M |
state/apiserver/provisioner/provisioner_test.go
|
View
|
1
2
|
4 chunks |
+30 lines, -22 lines |
0 comments
|
Download
|
|
M |
state/machine.go
|
View
|
1
2
3
4
|
5 chunks |
+29 lines, -19 lines |
0 comments
|
Download
|
|
M |
state/machine_test.go
|
View
|
1
2
3
4
|
10 chunks |
+85 lines, -52 lines |
0 comments
|
Download
|
|
M |
state/networkinterfaces.go
|
View
|
1
2
3
4
|
3 chunks |
+35 lines, -3 lines |
0 comments
|
Download
|
|
M |
state/networkinterfaces_test.go
|
View
|
1
2
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
state/networks.go
|
View
|
1
2
3
4
|
3 chunks |
+32 lines, -5 lines |
0 comments
|
Download
|
|
M |
state/networks_test.go
|
View
|
1
2
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
state/open.go
|
View
|
1
2
3
4
|
3 chunks |
+13 lines, -10 lines |
0 comments
|
Download
|
|
M |
state/state.go
|
View
|
1
2
3
|
6 chunks |
+41 lines, -16 lines |
2 comments
|
Download
|
|
M |
state/state_test.go
|
View
|
1
2
|
8 chunks |
+69 lines, -18 lines |
0 comments
|
Download
|
|
M |
worker/provisioner/provisioner_task.go
|
View
|
1
2
3
|
1 chunk |
+8 lines, -6 lines |
0 comments
|
Download
|
|
M |
worker/provisioner/provisioner_test.go
|
View
|
1
2
|
3 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
Total messages: 13
|