Issue 8600043: Removes remaining references to charm slider

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8600043: Removes remaining references to charm slider

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by j.c.sackett

Modified:
11 years ago

Reviewers:
mp+157956, jeff.pihach, rharding

Visibility:
Public.

Description

Removes remaining references to charm slider While the slider is gone, there were elements that still expected slider data; sliderCharms, sliderContainers, and the slider class in the template. All of these things are replaced by "featured" (e.g. featuredCharms), which is the new container category replacing the slider in the design. https://code.launchpad.net/~jcsackett/juju-gui/slider-means-featured/+merge/157956 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Removes remaining references to charm slider #

Patch Set 3 : Removes remaining references to charm slider #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/templates/sidebar.handlebars	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/subapps/browser/views/sidebar.js	View		2 chunks	+9 lines, -11 lines	0 comments	Download
M	test/data/sidebar_editorial.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

j.c.sackett

11 years ago (2013-04-10 17:14:59 UTC) #4

*** Submitted:

Removes remaining references to charm slider

While the slider is gone, there were elements that still expected slider data;
sliderCharms, sliderContainers, and the slider class in the template.

All of these things are replaced by "featured" (e.g. featuredCharms), which is
the new container category replacing the slider in the design.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/8600043

Expand All Messages | Collapse All Messages