Issue 8593050: Second round of UX bug fixes. Details below.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8593050: Second round of UX bug fixes. Details below.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by rharding

Modified:
10 years, 12 months ago

Reviewers:
mp+160615, j.c.sackett

Visibility:
Public.

Description

Second round of UX bug fixes. Details below. - Landed for Huw. - Fixes #1171520 - Fixes #1171523 - Fixes #1171541 - Fixes #1171546 https://code.launchpad.net/~rharding/juju-gui/uxbugs-2/+merge/160615 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Second round of UX bug fixes. Details below. #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -12 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/templates/charm-token.handlebars	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	lib/views/browser/charm-full.less	View	3 chunks	+6 lines, -7 lines	0 comments	Download
M	lib/views/browser/charm-token.less	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/views/browser/main.less	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/test_charm_token.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rharding

10 years, 12 months ago (2013-04-24 15:29:46 UTC) #4

*** Submitted:

Second round of UX bug fixes. Details below.

- Landed for Huw.
- Fixes #1171520
- Fixes #1171523
- Fixes #1171541
- Fixes #1171546

R=j.c.sackett
CC=
https://codereview.appspot.com/8593050

Expand All Messages | Collapse All Messages